Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 543823002: ozone: Plumb animated cursors from CursorLoaderOzone to CursorFactoryOzone (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: Plumb animated cursors from CursorLoaderOzone to CursorFactoryOzone Slice up the tiled image just like CursorLoaderX11 does and pass it on to CursorFactory as a vector, hotspot, and frame delay. Also add stub implementation for BitmapCursorFactoryOzone that just creates a static cursor with the initial frame. R=sky BUG=343245 TEST=viewed css "wait" cursor on cros link_freon Committed: https://crrev.com/baa7e5a474158e97b376ef61d662e328a9a9605c Cr-Commit-Position: refs/heads/master@{#293980}

Patch Set 1 #

Total comments: 2

Patch Set 2 : extract common bits into cursor_util #

Patch Set 3 : scale after assigning bitmap :( #

Patch Set 4 : s/0/0U/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -47 lines) Patch
M ui/base/cursor/cursor_loader_ozone.cc View 1 2 chunks +17 lines, -10 lines 0 comments Download
M ui/base/cursor/cursor_loader_x11.cc View 1 2 chunks +12 lines, -37 lines 0 comments Download
M ui/base/cursor/cursor_util.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M ui/base/cursor/cursor_util.cc View 1 2 2 chunks +50 lines, -0 lines 0 comments Download
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/cursor/ozone/bitmap_cursor_factory_ozone.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M ui/ozone/public/cursor_factory_ozone.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/ozone/public/cursor_factory_ozone.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
spang
6 years, 3 months ago (2014-09-04 19:19:43 UTC) #1
sky
https://codereview.chromium.org/543823002/diff/1/ui/base/cursor/cursor_loader_ozone.cc File ui/base/cursor/cursor_loader_ozone.cc (right): https://codereview.chromium.org/543823002/diff/1/ui/base/cursor/cursor_loader_ozone.cc#newcode54 ui/base/cursor/cursor_loader_ozone.cc:54: SkBitmap cropped = SkBitmapOperations::CreateTiledBitmap( Please refactor this as it ...
6 years, 3 months ago (2014-09-04 21:23:12 UTC) #2
spang
https://codereview.chromium.org/543823002/diff/1/ui/base/cursor/cursor_loader_ozone.cc File ui/base/cursor/cursor_loader_ozone.cc (right): https://codereview.chromium.org/543823002/diff/1/ui/base/cursor/cursor_loader_ozone.cc#newcode54 ui/base/cursor/cursor_loader_ozone.cc:54: SkBitmap cropped = SkBitmapOperations::CreateTiledBitmap( On 2014/09/04 21:23:12, sky wrote: ...
6 years, 3 months ago (2014-09-05 16:26:27 UTC) #3
sky
LGTM
6 years, 3 months ago (2014-09-05 22:39:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/543823002/20001
6 years, 3 months ago (2014-09-06 05:51:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11586)
6 years, 3 months ago (2014-09-06 07:03:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/543823002/20001
6 years, 3 months ago (2014-09-08 14:36:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11865)
6 years, 3 months ago (2014-09-08 15:39:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/543823002/40001
6 years, 3 months ago (2014-09-09 17:26:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/543823002/60001
6 years, 3 months ago (2014-09-09 18:01:28 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 1f890ed7484070280a626e3b744e2e952f0df64c
6 years, 3 months ago (2014-09-09 19:07:39 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:41 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/baa7e5a474158e97b376ef61d662e328a9a9605c
Cr-Commit-Position: refs/heads/master@{#293980}

Powered by Google App Engine
This is Rietveld 408576698