Using some C++11 goodness to cleanup the iterator code in SVGResourceCache.

Source/core/rendering/svg/SVGResourcesCache.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 42 matching lines @@
     SVGResources* resources = m_cache.set(object, newResources.release()).storedValue->value.get();
 
     // Run cycle-detection _afterwards_, so self-references can be caught as well.
     SVGResourcesCycleSolver solver(object, resources);
     solver.resolveCycles();
 
     // Walk resources and register the render object at each resources.
     HashSet<RenderSVGResourceContainer*> resourceSet;
     resources->buildSetOfResources(resourceSet);
 
-    HashSet<RenderSVGResourceContainer*>::iterator end = resourceSet.end();
-    for (HashSet<RenderSVGResourceContainer*>::iterator it = resourceSet.begin(); it != end; ++it)
-        (*it)->addClient(object);
+    for (auto* resourceContainer : resourceSet)
+        resourceContainer->addClient(object);
 }
 
 void SVGResourcesCache::removeResourcesFromRenderObject(RenderObject* object)
 {
     OwnPtr<SVGResources> resources = m_cache.take(object);
     if (!resources)
         return;
 
     // Walk resources and register the render object at each resources.
     HashSet<RenderSVGResourceContainer*> resourceSet;
     resources->buildSetOfResources(resourceSet);
 
-    HashSet<RenderSVGResourceContainer*>::iterator end = resourceSet.end();
-    for (HashSet<RenderSVGResourceContainer*>::iterator it = resourceSet.begin(); it != end; ++it)
-        (*it)->removeClient(object);
+    for (auto* resourceContainer : resourceSet)
+        resourceContainer->removeClient(object);
 }
 
 static inline SVGResourcesCache* resourcesCacheFromRenderObject(const RenderObject* renderer)
 {
     Document& document = renderer->document();
 
     SVGDocumentExtensions& extensions = document.accessSVGExtensions();
     SVGResourcesCache* cache = extensions.resourcesCache();
     ASSERT(cache);
 
@@ skipping 86 matching lines @@
 }
 
 void SVGResourcesCache::resourceDestroyed(RenderSVGResourceContainer* resource)
 {
     ASSERT(resource);
     SVGResourcesCache* cache = resourcesCacheFromRenderObject(resource);
 
     // The resource itself may have clients, that need to be notified.
     cache->removeResourcesFromRenderObject(resource);
 
-        CacheMap::iterator end = cache->m_cache.end();
-        for (CacheMap::iterator it = cache->m_cache.begin(); it != end; ++it) {
-        it->value->resourceDestroyed(resource);
+    for (auto& it : cache->m_cache) {

[Nico, 2014/09/25 21:23:34]

why "it"?

[Savago, 2014/09/25 21:41:43]

The original code used 'it' (I'm assuming for 'iterator'). Any preferences for
names here?

+        it.value->resourceDestroyed(resource);
 
         // Mark users of destroyed resources as pending resolution based on the id of the old resource.
         Element* resourceElement = resource->element();
-        Element* clientElement = toElement(it->key->node());
+        Element* clientElement = toElement(it.key->node());
         SVGDocumentExtensions& extensions = clientElement->document().accessSVGExtensions();
 
         extensions.addPendingResource(resourceElement->fastGetAttribute(HTMLNames::idAttr), clientElement);
     }
 }
 
 }