Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/perf/measurements/memory.py

Issue 543803004: Move heap profile dumping logic from memory measurement to tcmalloc_heap_profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/memory.py
diff --git a/tools/perf/measurements/memory.py b/tools/perf/measurements/memory.py
index f63cf3064a14505c77f4edb99ba8b55f739bd5f8..d8e913751757432eb767827fab87383199facde9 100644
--- a/tools/perf/measurements/memory.py
+++ b/tools/perf/measurements/memory.py
@@ -33,15 +33,3 @@ class Memory(page_test.PageTest):
self._memory_metric.Stop(page, tab)
self._memory_metric.AddResults(tab, results)
self._power_metric.AddResults(tab, results)
-
- if tab.browser.is_profiler_active('tcmalloc-heap'):
- # The tcmalloc_heap_profiler dumps files at regular
- # intervals (~20 secs).
- # This is a minor optimization to ensure it'll dump the last file when
- # the test completes.
- tab.ExecuteJavaScript("""
- if (chrome && chrome.memoryBenchmarking) {
- chrome.memoryBenchmarking.heapProfilerDump('renderer', 'final');
- chrome.memoryBenchmarking.heapProfilerDump('browser', 'final');
- }
- """)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698