Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 543803004: Move heap profile dumping logic from memory measurement to tcmalloc_heap_profiler. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
bulach, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move heap profile dumping logic from memory measurement to tcmalloc_heap_profiler. BUG= Committed: https://crrev.com/065e76059569294cf7813215d633090f0c1ea914 Cr-Commit-Position: refs/heads/master@{#293411}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M tools/perf/measurements/memory.py View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nednguyen
6 years, 3 months ago (2014-09-04 19:11:38 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-09-04 19:13:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/543803004/20001
6 years, 3 months ago (2014-09-04 19:15:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10305)
6 years, 3 months ago (2014-09-05 00:31:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/543803004/20001
6 years, 3 months ago (2014-09-05 01:04:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 7d2f8bc5cd19c0d78149055f6670e89c55ecae52
6 years, 3 months ago (2014-09-05 02:50:46 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:55 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/065e76059569294cf7813215d633090f0c1ea914
Cr-Commit-Position: refs/heads/master@{#293411}

Powered by Google App Engine
This is Rietveld 408576698