Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 543803002: Subzero: Work around another llvm-mc parser bug for relocatable symbols. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Work around another llvm-mc parser bug for relocatable symbols. There's already a hack that emits asm like: lea eax, myglobal instead of: mov eax, [myglobal] because of an llvm-mc parser bug. However, the lea hack still doesn't work if the symbol is a reserved word, e.g.: lea eax, flags The extra hack is to drop into AT&T syntax temporarily: .att_syntax leal flags, %eax .intel_syntax BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=523ef72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M src/IceInstX8632.cpp View 2 chunks +24 lines, -10 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-04 18:08:58 UTC) #2
jvoung (off chromium)
LGTM
6 years, 3 months ago (2014-09-04 18:22:49 UTC) #3
Jim Stichnoth
6 years, 3 months ago (2014-09-04 18:32:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 523ef72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698