Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 543783002: Resubmit: Add LocationBar PageAction tests (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Resubmit: Add LocationBar PageAction tests Original CL: https://codereview.chromium.org/512693003/ This was reverted because LocationBarBrowserTest.PageActionUITest is flaky on Mac. Resubmit this, but with the flaky test disabled on mac. BUG=408261 BUG=410866 Committed: https://crrev.com/65b063b53184d97bf17abeeeca8ff846bbe273cd Cr-Commit-Position: refs/heads/master@{#293364}

Patch Set 1 : Original Patch #

Patch Set 2 : Disable test on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -0 lines) Patch
A chrome/browser/ui/location_bar/location_bar_browsertest.cc View 1 1 chunk +165 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Hey Scott, please take a look when you can. It looks like the patch was ...
6 years, 3 months ago (2014-09-04 15:54:20 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-04 17:51:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/543783002/20001
6 years, 3 months ago (2014-09-04 19:18:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7714813d689e649c5087cfebb4138d5465b2e045
6 years, 3 months ago (2014-09-04 22:56:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65b063b53184d97bf17abeeeca8ff846bbe273cd
Cr-Commit-Position: refs/heads/master@{#293364}

Powered by Google App Engine
This is Rietveld 408576698