Issue 543763002: Remove overly complex MachineNodeFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543763002: Remove overly complex MachineNodeFactory. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+348 lines, -452 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/compiler/machine-node-factory.h	View	1 chunk	+0 lines, -374 lines	0 comments	Download
M	src/compiler/raw-machine-assembler.h	View	4 chunks	+330 lines, -5 lines	0 comments	Download
M	test/cctest/compiler/graph-builder-tester.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/compiler/simplified-graph-builder.h	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	test/cctest/compiler/structured-machine-assembler.h	View	4 chunks	+2 lines, -30 lines	0 comments	Download
M	test/cctest/compiler/structured-machine-assembler.cc	View	1 chunk	+2 lines, -36 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Michael Starzinger

6 years, 3 months ago (2014-09-04 16:29:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23702 (presubmit successful).