Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/suggestions/image_manager_unittest.cc

Issue 543753002: [Suggestions] Move ImageManager to the component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/suggestions/image_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions/image_manager_unittest.cc
diff --git a/components/suggestions/image_manager_unittest.cc b/components/suggestions/image_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..757b810f52a83442888c6d97ccbbbccdfff9e973
--- /dev/null
+++ b/components/suggestions/image_manager_unittest.cc
@@ -0,0 +1,193 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/files/file_path.h"
+#include "base/run_loop.h"
+#include "components/leveldb_proto/proto_database.h"
+#include "components/leveldb_proto/testing/fake_db.h"
+#include "components/suggestions/image_fetcher.h"
+#include "components/suggestions/image_fetcher_delegate.h"
+#include "components/suggestions/image_manager.h"
+#include "components/suggestions/proto/suggestions.pb.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/image/image_skia.h"
+#include "url/gurl.h"
+
+using ::testing::Return;
+using ::testing::StrictMock;
+using ::testing::_;
+
+namespace suggestions {
+
+const char kTestUrl1[] = "http://go.com/";
+const char kTestUrl2[] = "http://goal.com/";
+const char kTestImagePath[] = "files/image_decoding/droids.png";
+const char kInvalidImagePath[] = "files/DOESNOTEXIST";
+
+using leveldb_proto::test::FakeDB;
+using suggestions::ImageData;
+using suggestions::ImageManager;
+
+typedef base::hash_map<std::string, ImageData> EntryMap;
+
+void AddEntry(const ImageData& d, EntryMap* map) { (*map)[d.url()] = d; }
+
+class MockImageFetcher : public suggestions::ImageFetcher {
+ public:
+ MockImageFetcher() {}
+ virtual ~MockImageFetcher() {}
+ MOCK_METHOD3(StartOrQueueNetworkRequest,
+ void(const GURL&, const GURL&,
+ base::Callback<void(const GURL&, const SkBitmap*)>));
+ MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*));
+};
+
+class ImageManagerTest : public testing::Test {
+ public:
+ ImageManagerTest()
+ : mock_image_fetcher_(NULL),
+ num_callback_null_called_(0),
+ num_callback_valid_called_(0) {}
+
+ virtual void SetUp() OVERRIDE {
+ fake_db_ = new FakeDB<ImageData>(&db_model_);
+ image_manager_.reset(CreateImageManager(fake_db_));
+ }
+
+ virtual void TearDown() OVERRIDE {
+ fake_db_ = NULL;
+ db_model_.clear();
+ image_manager_.reset();
+ }
+
+ void InitializeDefaultImageMapAndDatabase(ImageManager* image_manager,
+ FakeDB<ImageData>* fake_db) {
+ CHECK(image_manager);
+ CHECK(fake_db);
+
+ suggestions::SuggestionsProfile suggestions_profile;
+ suggestions::ChromeSuggestion* suggestion =
+ suggestions_profile.add_suggestions();
+ suggestion->set_url(kTestUrl1);
+ suggestion->set_thumbnail(kTestImagePath);
+
+ image_manager->Initialize(suggestions_profile);
+
+ // Initialize empty database.
+ fake_db->InitCallback(true);
+ fake_db->LoadCallback(true);
+ }
+
+ ImageData GetSampleImageData(const std::string& url) {
+ // Create test bitmap.
+ SkBitmap bm;
+ bm.allocN32Pixels(2, 2);
+ ImageData data;
+ data.set_url(url);
+ std::vector<unsigned char> encoded;
+ EXPECT_TRUE(ImageManager::EncodeImage(bm, &encoded));
+ data.set_data(std::string(encoded.begin(), encoded.end()));
+ return data;
+ }
+
+ void OnImageAvailable(base::RunLoop* loop, const GURL& url,
+ const SkBitmap* bitmap) {
+ if (bitmap) {
+ num_callback_valid_called_++;
+ } else {
+ num_callback_null_called_++;
+ }
+ loop->Quit();
+ }
+
+ ImageManager* CreateImageManager(FakeDB<ImageData>* fake_db) {
+ mock_image_fetcher_ = new StrictMock<MockImageFetcher>();
+ EXPECT_CALL(*mock_image_fetcher_, SetImageFetcherDelegate(_));
+ return new ImageManager(
+ scoped_ptr<ImageFetcher>(mock_image_fetcher_),
+ scoped_ptr<leveldb_proto::ProtoDatabase<ImageData> >(fake_db),
+ FakeDB<ImageData>::DirectoryForTestDB());
+ }
+
+ EntryMap db_model_;
+ // Owned by the ImageManager under test.
+ FakeDB<ImageData>* fake_db_;
+
+ MockImageFetcher* mock_image_fetcher_;
+
+ int num_callback_null_called_;
+ int num_callback_valid_called_;
+ // Under test.
+ scoped_ptr<ImageManager> image_manager_;
+};
+
+TEST_F(ImageManagerTest, InitializeTest) {
+ SuggestionsProfile suggestions_profile;
+ ChromeSuggestion* suggestion = suggestions_profile.add_suggestions();
+ suggestion->set_url(kTestUrl1);
+ suggestion->set_thumbnail(kTestImagePath);
+
+ image_manager_->Initialize(suggestions_profile);
+
+ GURL output;
+ EXPECT_TRUE(image_manager_->GetImageURL(GURL(kTestUrl1), &output));
+ EXPECT_EQ(GURL(kTestImagePath), output);
+
+ EXPECT_FALSE(image_manager_->GetImageURL(GURL("http://b.com"), &output));
+}
+
+TEST_F(ImageManagerTest, GetImageForURLNetwork) {
+ InitializeDefaultImageMapAndDatabase(image_manager_.get(), fake_db_);
+
+ // We expect the fetcher to go to network and call the callback.
+ EXPECT_CALL(*mock_image_fetcher_, StartOrQueueNetworkRequest(_, _, _));
+
+ // Fetch existing URL.
+ base::RunLoop run_loop;
+ image_manager_->GetImageForURL(GURL(kTestUrl1),
+ base::Bind(&ImageManagerTest::OnImageAvailable,
+ base::Unretained(this), &run_loop));
+
+ // Will not go to network and use the fetcher since URL is invalid.
+ // Fetch non-existing URL.
+ image_manager_->GetImageForURL(GURL(kTestUrl2),
+ base::Bind(&ImageManagerTest::OnImageAvailable,
+ base::Unretained(this), &run_loop));
+ run_loop.Run();
+
+ EXPECT_EQ(1, num_callback_null_called_);
+}
+
+TEST_F(ImageManagerTest, GetImageForURLNetworkCacheHit) {
+ SuggestionsProfile suggestions_profile;
+ ChromeSuggestion* suggestion = suggestions_profile.add_suggestions();
+ suggestion->set_url(kTestUrl1);
+ // The URL we set is invalid, to show that it will fail from network.
+ suggestion->set_thumbnail(kInvalidImagePath);
+
+ // Create the ImageManager with an added entry in the database.
+ AddEntry(GetSampleImageData(kTestUrl1), &db_model_);
+ FakeDB<ImageData>* fake_db = new FakeDB<ImageData>(&db_model_);
+ image_manager_.reset(CreateImageManager(fake_db));
+ image_manager_->Initialize(suggestions_profile);
+ fake_db->InitCallback(true);
+ fake_db->LoadCallback(true);
+ // Expect something in the cache.
+ SkBitmap* bitmap = image_manager_->GetBitmapFromCache(GURL(kTestUrl1));
+ EXPECT_FALSE(bitmap->isNull());
+
+ base::RunLoop run_loop;
+ image_manager_->GetImageForURL(GURL(kTestUrl1),
+ base::Bind(&ImageManagerTest::OnImageAvailable,
+ base::Unretained(this), &run_loop));
+ run_loop.Run();
+
+ EXPECT_EQ(0, num_callback_null_called_);
+ EXPECT_EQ(1, num_callback_valid_called_);
+}
+
+} // namespace suggestions
« no previous file with comments | « components/suggestions/image_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698