[Suggestions] Move ImageManager to the component

components/suggestions/image_fetcher.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_IMPL_H_

[huangs, 2014/09/22 21:51:13]

Remove _IMPL_

[Mathieu, 2014/09/23 14:59:06]

Good catch

+#define COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_IMPL_H_
+
+#include <map>

[huangs, 2014/09/22 21:51:14]

These STD includes are not needed.

[Mathieu, 2014/09/23 14:59:06]

Done.

+#include <utility>
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/callback.h"
+#include "components/suggestions/image_fetcher_delegate.h"
+#include "ui/gfx/image/image_skia.h"

[huangs, 2014/09/22 21:51:13]

Can forward declare SkBitmap ?

What's basictypes.h used for?

[Mathieu, 2014/09/23 14:59:06]

Done.

+#include "url/gurl.h"
+
+namespace net {
+class URLRequestContextGetter;

[huangs, 2014/09/22 21:51:13]

Unused.

[Mathieu, 2014/09/23 14:59:06]

Done.

+}
+
+namespace suggestions {
+
+// A class used to fetch server images.
+class ImageFetcher  {
+ public:
+  ImageFetcher() {}
+  virtual ~ImageFetcher() {}
+
+  virtual void SetImageFetcherDelegate(ImageFetcherDelegate* delegate) = 0;
+
+  virtual void StartOrQueueNetworkRequest(
+      const GURL& url, const GURL& image_url,
+      base::Callback<void(const GURL&, const SkBitmap*)> callback) = 0;
+};

[huangs, 2014/09/22 21:51:13]

DISALLOW_COPY_AND_ASSIGN?

[Mathieu, 2014/09/23 14:59:06]

Done.

+
+}  // namespace suggestions
+
+#endif  // COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_IMPL_H_