Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

Issue 543753002: [Suggestions] Move ImageManager to the component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pointer fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/search/suggestions/image_fetcher_impl.h"
6
7 #include <string>
huangs 2014/09/24 15:46:57 Doesn't look like these are used.
Mathieu 2014/09/24 19:31:30 Done.
8 #include <vector>
9
10 #include "base/bind.h"
11 #include "base/files/file_path.h"
12 #include "base/memory/scoped_ptr.h"
13 #include "base/run_loop.h"
14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/browser.h"
16 #include "chrome/test/base/in_process_browser_test.h"
17 #include "components/suggestions/image_fetcher_delegate.h"
18 #include "net/test/spawned_test_server/spawned_test_server.h"
19 #include "testing/gtest/include/gtest/gtest.h"
20 #include "url/gurl.h"
21
22 class SkBitmap;
23
24 namespace suggestions {
25
26 namespace {
27
28 const char kTestUrl[] = "http://go.com/";
29 const char kTestImagePath[] = "files/image_decoding/droids.png";
30 const char kInvalidImagePath[] = "files/DOESNOTEXIST";
31
32 const base::FilePath::CharType kDocRoot[] =
33 FILE_PATH_LITERAL("chrome/test/data");
34
35 class TestImageFetcherDelegate : public ImageFetcherDelegate {
36 public:
37 TestImageFetcherDelegate()
38 : num_delegate_valid_called_(0),
39 num_delegate_null_called_(0) {}
40 virtual ~TestImageFetcherDelegate() {};
41
42 // Perform additional tasks when an image has been fetched.
43 virtual void OnImageFetched(const GURL& url, const SkBitmap* bitmap)
44 OVERRIDE {
45 if (bitmap) {
46 num_delegate_valid_called_++;
47 } else {
48 num_delegate_null_called_++;
49 }
50 };
51
52 int num_delegate_valid_called() { return num_delegate_valid_called_; }
53 int num_delegate_null_called() { return num_delegate_null_called_; }
54
55 private:
56 int num_delegate_valid_called_;
57 int num_delegate_null_called_;
58 };
59
60 } // end namespace
61
62 class ImageFetcherImplBrowserTest : public InProcessBrowserTest {
63 protected:
64 ImageFetcherImplBrowserTest()
65 : num_callback_valid_called_(0),
66 num_callback_null_called_(0),
67 test_server_(net::SpawnedTestServer::TYPE_HTTP,
68 net::SpawnedTestServer::kLocalhost,
69 base::FilePath(kDocRoot)) {}
70
71 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
72 ASSERT_TRUE(test_server_.Start());
73 InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
74 }
75
76 virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
77 test_server_.Stop();
78 }
79
80 ImageFetcherImpl* CreateImageFetcher() {
81 ImageFetcherImpl* fetcher =
82 new ImageFetcherImpl(browser()->profile()->GetRequestContext());
83 fetcher->SetImageFetcherDelegate(&delegate_);
84 return fetcher;
85 }
86
87 void OnImageAvailable(base::RunLoop* loop,
88 const GURL& url,
89 const SkBitmap* bitmap) {
90 if (bitmap) {
91 num_callback_valid_called_++;
92 } else {
93 num_callback_null_called_++;
94 }
95 loop->Quit();
96 }
97
98 void StartOrQueueNetworkRequestHelper(const GURL& image_url) {
99 scoped_ptr<ImageFetcherImpl> image_fetcher_(CreateImageFetcher());
100
101 base::RunLoop run_loop;
102 image_fetcher_->StartOrQueueNetworkRequest(
103 GURL(kTestUrl),
104 image_url,
105 base::Bind(&ImageFetcherImplBrowserTest::OnImageAvailable,
106 base::Unretained(this), &run_loop));
107 run_loop.Run();
108 }
109
110 int num_callback_valid_called_;
111 int num_callback_null_called_;
112
113 net::SpawnedTestServer test_server_;
114 TestImageFetcherDelegate delegate_;
115
116 DISALLOW_COPY_AND_ASSIGN(ImageFetcherImplBrowserTest);
117 };
118
119 IN_PROC_BROWSER_TEST_F(ImageFetcherImplBrowserTest, NormalFetch) {
120 GURL image_url(test_server_.GetURL(kTestImagePath).spec());
121 StartOrQueueNetworkRequestHelper(image_url);
122
123 EXPECT_EQ(1, num_callback_valid_called_);
124 EXPECT_EQ(0, num_callback_null_called_);
125 EXPECT_EQ(1, delegate_.num_delegate_valid_called());
126 EXPECT_EQ(0, delegate_.num_delegate_null_called());
127 }
128
129 IN_PROC_BROWSER_TEST_F(ImageFetcherImplBrowserTest, MultipleFetch) {
130 GURL image_url(test_server_.GetURL(kTestImagePath).spec());
131
132 for (int i = 0; i < 5; i++) {
133 StartOrQueueNetworkRequestHelper(image_url);
134 }
135
136 EXPECT_EQ(5, num_callback_valid_called_);
137 EXPECT_EQ(0, num_callback_null_called_);
138 EXPECT_EQ(5, delegate_.num_delegate_valid_called());
139 EXPECT_EQ(0, delegate_.num_delegate_null_called());
140 }
141
142 IN_PROC_BROWSER_TEST_F(ImageFetcherImplBrowserTest, InvalidFetch) {
143 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec());
144 StartOrQueueNetworkRequestHelper(invalid_image_url);
145
146 EXPECT_EQ(0, num_callback_valid_called_);
147 EXPECT_EQ(1, num_callback_null_called_);
148 EXPECT_EQ(0, delegate_.num_delegate_valid_called());
149 EXPECT_EQ(1, delegate_.num_delegate_null_called());
150 }
151
152 } // namespace suggestions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698