Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 543743003: Changes the ninja generator to output phony targets for uninteresting targets (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Changes the ninja generator to output phony targets for uninteresting targets This way you can pass these targets to the build system and not get errors. BUG=410410 TEST=covered by test now R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M pylib/gyp/generator/ninja.py View 3 chunks +15 lines, -0 lines 0 comments Download
A test/empty-target/empty-target.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
A test/empty-target/gyptest-empty-target.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
6 years, 3 months ago (2014-09-04 17:49:34 UTC) #2
Nico
lgtm if the test passes on all build systems. Thanks!
6 years, 3 months ago (2014-09-04 17:55:14 UTC) #3
sky
I'm going to land. My first try failed on gyp-win64, but my second try passed. ...
6 years, 3 months ago (2014-09-04 23:59:29 UTC) #4
sky
Committed patchset #1 (id:1) manually as r1973 (presubmit successful).
6 years, 3 months ago (2014-09-04 23:59:57 UTC) #5
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-08 08:04:45 UTC) #7
Message was sent while issue was closed.
this broke compilation, as we now output empty phony rules for already existing
rules.

Powered by Google App Engine
This is Rietveld 408576698