Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 543743002: Remove deprecated PrintableUnique. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove deprecated PrintableUnique. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -178 lines) Patch
M src/compiler/ast-graph-builder.cc View 11 chunks +11 lines, -12 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/graph-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/graph-unittest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/graph-unittest.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/js-operator.h View 5 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/machine-node-factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/operator.h View 3 chunks +16 lines, -22 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/unique.h View 2 chunks +0 lines, -69 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-04 12:34:55 UTC) #1
titzer
On 2014/09/04 12:34:55, Michael Starzinger wrote: LGTM
6 years, 3 months ago (2014-09-04 12:49:12 UTC) #2
Michael Starzinger
Committed patchset #1 (id:1) manually as 23697 (presubmit successful).
6 years, 3 months ago (2014-09-04 13:45:26 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-09-05 03:51:13 UTC) #5
Message was sent while issue was closed. 
LGTM, Thanks!

Powered by Google App Engine
This is Rietveld 408576698