Rework bot and test parsing to allow receipt of (bot, set(test)) specifications.

Rework bot and test parsing to allow receipt of (bot, set(test)) specifications.

This is needed for a further CL to unify TS and CQ using PRESUBMIT.py.

BUG=278554
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=232813

[ghost stip (do not use), 2013-11-01 02:13:00]

This modifies the handling of bot/test handling in trychange.py and
presubmit_support.py. The reason for this change is to allow PRESUBMIT.py to
deliver detailed test information instead of just trybot names. This gets us to
unifying TS/CQ configs.

I have opted to check for and honor previous PRESUBMIT.py behavior in case we
have other teams using gclient.py. If other people aren't using it (only
chrome/src) then we can delete the old-style and only have the new-style code.

Note that there is a slight difference in behavior here: --testfilter is now
applied when previously it was ignored for bots specified on the CLI. Example:

============ with this patch ============
aesir2 src(worp)> git try --print_bots --bot bot1,bot2 --testfilter=yo          
                                                                                
                                                                       
Results will be emailed to: stip@chromium.org
Bots which would be used:
  bot1:yo
  bot2:yo

============ with depot_tools@4f4e76fce ============
aesir2 src(worp)> git try --print_bots --bot bot1,bot2 --testfilter=yo
Results will be emailed to: stip@chromium.org
Bots which would be used:
  bot1,bot2


I have tested this on the following configurations and the patched version is
the same as standard depot_tools, with the exception described above. I have
also tested it with a 'new-style' PRESUBMIT.py and it functions as expected.

I think this change is solid, but please take a second look.

--bot bot1:hey,bot2
--bot bot1,bot2 --testfilter=gnarl,gnarl2
--bot bot2 --testfilter=gnarl,gnarl2
--bot bot1 --bot bot2
--bot bot1,bot2
--bot bot1:hey --bot bot2 --testfilter=gnarl,gnarl2
--bot bot1:hey,bot2 --testfilter=gnarl,gnarl2
--bot bot1:compile,bot2 --testfilter=gnarl,gnarl2
--bot bot1:hey --bot bot2
--bot bot1:hey,yeah --bot bot2
--bot bot1:hey,yeah --bot bot2:twang

https://codereview.chromium.org/54373011/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/54373011/diff/1/presubmit_support.py#newcode1103
presubmit_support.py:1103: slaves = list(set(results))
looks like it would just update slaves after each run, so the indent worked even
though it should have been one less

[M-A Ruel, 2013-11-01 13:13:57]

https://codereview.chromium.org/54373011/diff/30001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/54373011/diff/30001/presubmit_support.py#newc...
presubmit_support.py:1034: if not isinstance(item, basestring):
Use positive checks instead of negative checks.

if isinstance(item, tuple):
  ...
elif isinstance(item, basestring):
  ...
else:
  raise YoDawg()

https://codereview.chromium.org/54373011/diff/30001/presubmit_support.py#newc...
presubmit_support.py:1095: if results and isinstance(results[0], tuple):
do you want to use all()?
I'd prefer to enforce:
 all(isinstance(i, basestring) for i in results) or all(isinstance(i, tuple) for
i in results)
but no mix and match. Your code is less resistant.

https://codereview.chromium.org/54373011/diff/30001/trychange.py
File trychange.py (right):

https://codereview.chromium.org/54373011/diff/30001/trychange.py#newcode398
trychange.py:398: 
lines

[ghost stip (do not use), 2013-11-04 22:01:52]

updated. ptal

https://codereview.chromium.org/54373011/diff/30001/trychange.py
File trychange.py (right):

https://codereview.chromium.org/54373011/diff/30001/trychange.py#newcode398
trychange.py:398: 
On 2013/11/01 13:13:57, M-A Ruel wrote:
> lines

Done.

[M-A Ruel, 2013-11-04 22:05:33]

lgtm

good luck

https://codereview.chromium.org/54373011/diff/130001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/54373011/diff/130001/presubmit_support.py#new...
presubmit_support.py:9: __version__ = '1.6.2'
bump

https://codereview.chromium.org/54373011/diff/130001/trychange.py
File trychange.py (right):

https://codereview.chromium.org/54373011/diff/130001/trychange.py#newcode319
trychange.py:319: """Parses bot configurations from the command line."""
from a list of strings

[commit-bot: I haz the power, 2013-11-04 22:12:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/54373011/190001

[commit-bot: I haz the power, 2013-11-04 22:14:40]

Change committed as 232813