Reduce the number of Uris parsed in builtin.

runtime/bin/builtin.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library builtin;
 import 'dart:io';
 import 'dart:async';
 import 'dart:convert';
 // import 'root_library'; happens here from C Code
 
@@ skipping 154 matching lines @@
 // Returns either a file path or a URI starting with http:, as a String.
 String _filePathFromUri(String userUri) {
   var uri = Uri.parse(userUri);
   _logResolution('# Getting file path from: $uri');
 
   var path;
   switch (uri.scheme) {
     case '':
     case 'file':
       return uri.toFilePath();
-      break;
     case 'package':
       return _filePathFromPackageUri(uri);
-      break;
     case 'http':
       return uri.toString();
     default:
       // Only handling file, http, and package URIs
       // in standalone binary.
       _logResolution('# Unknown scheme (${uri.scheme}) in $uri.');
       throw 'Not a known scheme: $uri';
   }
 }
 
@@ skipping 86 matching lines @@
   _logResolution("_asyncLoadError($uri), error: $error");
   _numOutstandingLoadRequests--;
   _asyncLoadErrorCallback(uri, libraryUri, error);
   if (_numOutstandingLoadRequests == 0) {
     _signalDoneLoading();
     _cleanup();
   }
 }
 
 
+// Create a Uri of 'userUri'. Is the input uri is a package uri, the package uri

[Ivan Posva, 2014/09/04 15:33:18]

If the input uri ..., then the package ...

[Anders Johnsen, 2014/09/05 05:33:24]

Done.

+// is resolved.
+Uri _createUri(String userUri) {
+  var uri = Uri.parse(userUri);
+  _logResolution('# Creating uri for: $uri');
+
+  switch (uri.scheme) {
+    case '':
+    case 'file':
+    case 'http':
+      return uri;
+    case 'package':
+      return Uri.parse(_filePathFromPackageUri(uri));
+    default:
+      // Only handling file, http, and package URIs
+      // in standalone binary.
+      _logResolution('# Unknown scheme (${uri.scheme}) in $uri.');
+      throw 'Not a known scheme: $uri';
+  }
+}
+
+
 // Asynchronously loads script data through a http or file uri.
 _loadDataAsync(int tag, String uri, String libraryUri) {
-  var filePath;
-  Uri sourceUri;
   if (tag == null) {
     uri = _resolveScriptUri(uri);
-    sourceUri = Uri.parse(uri);
-    filePath = _filePathFromUri(uri);
-  } else {
-    filePath = _filePathFromUri(uri);
-    sourceUri = Uri.parse(filePath);
   }
+  Uri resourceUri = _createUri(uri);
   _numOutstandingLoadRequests++;
   _logResolution("_loadDataAsync($uri), "
                  "${_numOutstandingLoadRequests} requests outstanding");
-  if (sourceUri.scheme == 'http') {
-    _httpGet(sourceUri, libraryUri, (data) {
+  if (resourceUri.scheme == 'http') {
+    _httpGet(resourceUri, libraryUri, (data) {
       _loadScript(tag, uri, libraryUri, data);
     });
   } else {
-    var sourceFile = new File(filePath);
+    var sourceFile = new File(resourceUri.toFilePath());
     sourceFile.readAsBytes().then((data) {
       _loadScript(tag, uri, libraryUri, data);
     },
     onError: (e) {
       _asyncLoadError(uri, libraryUri, e);
     });
   }
 }
 
 // Returns the directory part, the filename part, and the name
@@ skipping 34 matching lines @@
   } else if (Platform.isWindows) {
     filename = '$name.dll';
   } else {
     _logResolution(
         'Native extensions not supported on ${Platform.operatingSystem}');
     throw 'Native extensions not supported on ${Platform.operatingSystem}';
   }
 
   return [path, filename, name];
 }