Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 543703003: Use video-only test clips for media_perftests video benchmarks. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use video-only test clips for media_perftests video benchmarks. During development I noticed that the clips we were using contained audio, which would mean changes to audio-only code were impacting these benchmarks. This will cause our tests to use a new baseline, but that's OK. R=rileya@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/52e5986b93044eef5885e70b50f132d2b6d99c45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M media/filters/pipeline_integration_perftest.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
6 years, 3 months ago (2014-09-04 18:12:29 UTC) #2
rileya (GONE FROM CHROMIUM)
lgtm
6 years, 3 months ago (2014-09-04 18:15:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/543703003/1
6 years, 3 months ago (2014-09-04 18:29:02 UTC) #5
scherkus (not reviewing)
Committed patchset #1 (id:1) manually as 52e5986 (presubmit successful).
6 years, 3 months ago (2014-09-04 19:49:19 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52e5986b93044eef5885e70b50f132d2b6d99c45
Cr-Commit-Position: refs/heads/master@{#293325}

Powered by Google App Engine
This is Rietveld 408576698