chrome/browser/extensions/extension_service.h - Issue 543693003: Cleanup: Remove some deprecated ExtensionService usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 543693003: Cleanup: Remove some deprecated ExtensionService usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc ('k') | chrome/browser/extensions/extension_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.h

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h

index b31157b118041e83cd102565694ca8974f8eff89..e0e17e78b10feb6d5816067ee82798e83c7116c5 100644

--- a/chrome/browser/extensions/extension_service.h

+++ b/chrome/browser/extensions/extension_service.h

@@ -258,6 +258,9 @@ class ExtensionService

// Reloads the specified extension, sending the onLaunched() event to it if it

// currently has any window showing.

// Allows noisy failures.

+ // NOTE: Reloading an extension can invalidate |extension_id| and Extension

+ // pointers for the given extension. Consider making a copy of |extension_id|

+ // first and retrieving a new Extension pointer afterwards.

void ReloadExtension(const std::string& extension_id);

// Suppresses noisy failures.

« no previous file with comments | « chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc ('k') | chrome/browser/extensions/extension_util.cc » ('j') | no next file with comments »