Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(795)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: components/sad_tab/OWNERS
Issue
543663002
:
Componentize sad_tab (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix url_constants.cc
Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/app/generated_resources.grd
chrome/app/theme/default_100_percent/common/killtab.png
chrome/app/theme/default_100_percent/common/sadtab.png
chrome/app/theme/default_200_percent/common/sadtab.png
chrome/app/theme/theme_resources.grd
chrome/browser/resources/crashes.css
chrome/browser/ui/BUILD.gn
chrome/browser/ui/DEPS
chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
chrome/browser/ui/chrome_sad_tab_client.h
chrome/browser/ui/chrome_sad_tab_client.cc
chrome/browser/ui/cocoa/browser_window_controller.mm
chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h
chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h
chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm
chrome/browser/ui/cocoa/tab_contents/sad_tab_view_unittest.mm
chrome/browser/ui/sad_tab.h
chrome/browser/ui/sad_tab.cc
chrome/browser/ui/sad_tab_helper.h
chrome/browser/ui/sad_tab_helper.cc
chrome/browser/ui/sad_tab_types.h
chrome/browser/ui/tab_helpers.cc
chrome/browser/ui/views/sad_tab_view.h
chrome/browser/ui/views/sad_tab_view.cc
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
chrome/browser/ui/zoom/zoom_controller.cc
chrome/chrome_browser_ui.gypi
chrome/chrome_nibs.gyp
chrome/chrome_tests_unit.gypi
chrome/common/url_constants.h
chrome/common/url_constants.cc
components/BUILD.gn
components/OWNERS
components/components.gyp
components/components_strings.grd
components/components_tests.gyp
components/resources/components_scaled_resources.grd
components/resources/default_100_percent/common/sad_tab/killtab.png
components/resources/default_100_percent/common/sad_tab/sadtab.png
components/resources/default_200_percent/common/sad_tab/sadtab.png
components/resources/sad_tab_scaled_resources.grdp
components/sad_tab.gypi
components/sad_tab/BUILD.gn
components/sad_tab/DEPS
components/sad_tab/OWNERS
components/sad_tab/cocoa/DEPS
components/sad_tab/cocoa/sad_tab_controller.h
components/sad_tab/cocoa/sad_tab_controller.mm
components/sad_tab/cocoa/sad_tab_controller_unittest.mm
components/sad_tab/cocoa/sad_tab_view.h
components/sad_tab/cocoa/sad_tab_view.mm
components/sad_tab/cocoa/sad_tab_view_unittest.mm
components/sad_tab/sad_tab.h
components/sad_tab/sad_tab.cc
components/sad_tab/sad_tab_client.h
components/sad_tab/sad_tab_helper.h
components/sad_tab/sad_tab_helper.cc
components/sad_tab/sad_tab_types.h
components/sad_tab/url_constants.h
components/sad_tab/url_constants.cc
components/sad_tab/views/DEPS
components/sad_tab/views/sad_tab_view.h
components/sad_tab/views/sad_tab_view.cc
components/sad_tab_strings.grdp
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« components/sad_tab/DEPS
('k') |
components/sad_tab/cocoa/DEPS »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: components/sad_tab/OWNERS
diff --git a/chrome/browser/ui/views/OWNERS b/components/sad_tab/OWNERS
similarity index 100%
copy from chrome/browser/ui/views/OWNERS
copy to components/sad_tab/OWNERS
« no previous file with comments
|
« components/sad_tab/DEPS
('k') |
components/sad_tab/cocoa/DEPS »
('j') |
no next file with comments »
Issue 543663002: Componentize sad_tab (Closed)
Created 6 years, 3 months ago by hashimoto
Modified 6 years, 1 month ago
Reviewers: blundell, sadrul, msw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 13
This is Rietveld
408576698