Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix url_constants.cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 4918b476084b52da3aa6da7e64c0edebaf3f0f3a..bfed9cc35c4a4427e25769203b87312a21c053db 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -62,7 +62,6 @@
#import "chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h"
#import "chrome/browser/ui/cocoa/status_bubble_mac.h"
#import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
-#import "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h"
#import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
#import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
#import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
@@ -80,10 +79,11 @@
#include "chrome/browser/ui/window_sizer/window_sizer.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/command.h"
-#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/locale_settings.h"
#include "components/bookmarks/browser/bookmark_model.h"
+#import "components/sad_tab/cocoa/sad_tab_controller.h"
+#include "components/sad_tab/url_constants.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_ui_delegate.h"
@@ -1915,7 +1915,7 @@ using content::WebContents;
WebContents* webContents = [sadTab webContents];
if (webContents) {
OpenURLParams params(
- GURL(chrome::kCrashReasonURL), Referrer(), CURRENT_TAB,
+ GURL(sad_tab::kCrashReasonURL), Referrer(), CURRENT_TAB,
ui::PAGE_TRANSITION_LINK, false);
webContents->OpenURL(params);
}
« no previous file with comments | « chrome/browser/ui/chrome_sad_tab_client.cc ('k') | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698