chrome/browser/ui/bookmarks/bookmark_tab_helper.cc - Issue 543663002: Componentize sad_tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix url_constants.cc Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

index 0e9e50637f7cbfb48ef070fb2dd8426768fb310c..43607461c661f16143676d1811b3c7a9564b88df 100644

--- a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

@@ -11,10 +11,10 @@

#include "chrome/browser/search/search.h"

#include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h"

#include "chrome/browser/ui/bookmarks/bookmark_utils.h"

-#include "chrome/browser/ui/sad_tab.h"

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

#include "chrome/common/pref_names.h"

#include "components/bookmarks/browser/bookmark_model.h"

+#include "components/sad_tab/sad_tab.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

@@ -54,7 +54,7 @@ bool BookmarkTabHelper::ShouldShowBookmarkBar() const {

if (web_contents()->ShowingInterstitialPage())

return false;

- if (chrome::SadTab::ShouldShow(web_contents()->GetCrashedStatus()))

+ if (sad_tab::SadTab::ShouldShow(web_contents()->GetCrashedStatus()))

return false;

if (!browser_defaults::bookmarks_enabled)

« no previous file with comments | « chrome/browser/ui/DEPS ('k') | chrome/browser/ui/chrome_sad_tab_client.h » ('j') | no next file with comments »