Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/ui/sad_tab_helper.cc

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix url_constants.cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.h ('k') | chrome/browser/ui/sad_tab_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sad_tab_helper.cc
diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc
deleted file mode 100644
index ab8a6e034ea0d62936f59147d5f36a64856817e1..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/sad_tab_helper.cc
+++ /dev/null
@@ -1,48 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/sad_tab_helper.h"
-
-#include "base/logging.h"
-#include "chrome/browser/browser_shutdown.h"
-#include "chrome/browser/ui/sad_tab.h"
-#include "content/public/browser/web_contents.h"
-
-DEFINE_WEB_CONTENTS_USER_DATA_KEY(SadTabHelper);
-
-SadTabHelper::~SadTabHelper() {
-}
-
-SadTabHelper::SadTabHelper(content::WebContents* web_contents)
- : content::WebContentsObserver(web_contents) {
-}
-
-void SadTabHelper::RenderViewReady() {
- if (sad_tab_) {
- sad_tab_->Close();
- sad_tab_.reset();
- }
-}
-
-void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {
- // Only show the sad tab if we're not in browser shutdown, so that WebContents
- // objects that are not in a browser (e.g., HTML dialogs) and thus are
- // visible do not flash a sad tab page.
- if (browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID)
- return;
-
- if (sad_tab_)
- return;
-
- if (chrome::SadTab::ShouldShow(status))
- InstallSadTab(status);
-}
-
-void SadTabHelper::InstallSadTab(base::TerminationStatus status) {
- chrome::SadTabKind kind =
- (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) ?
- chrome::SAD_TAB_KIND_KILLED : chrome::SAD_TAB_KIND_CRASHED;
- sad_tab_.reset(chrome::SadTab::Create(web_contents(), kind));
- sad_tab_->Show();
-}
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.h ('k') | chrome/browser/ui/sad_tab_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698