Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/sad_tab/sad_tab.h

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sad_tab/sad_tab.h
diff --git a/chrome/browser/ui/sad_tab.h b/components/sad_tab/sad_tab.h
similarity index 62%
rename from chrome/browser/ui/sad_tab.h
rename to components/sad_tab/sad_tab.h
index e22b14948072cf051583412bce85faf415b8bf81..3de321ed183da5bd2da7c0d08fe483fae0dd5673 100644
--- a/chrome/browser/ui/sad_tab.h
+++ b/components/sad_tab/sad_tab.h
@@ -2,23 +2,27 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_SAD_TAB_H_
-#define CHROME_BROWSER_UI_SAD_TAB_H_
+#ifndef COMPONENTS_SAD_TAB_SAD_TAB_H_
+#define COMPONENTS_SAD_TAB_SAD_TAB_H_
#include "base/process/kill.h"
-#include "chrome/browser/ui/sad_tab_types.h"
+#include "components/sad_tab/sad_tab_types.h"
namespace content {
class WebContents;
}
-namespace chrome {
+namespace sad_tab {
+
+class SadTabClient;
// Cross-platform interface to show the Sad tab UI.
class SadTab {
public:
// Factory function to create the platform specific implementations.
- static SadTab* Create(content::WebContents* web_contents, SadTabKind kind);
+ static SadTab* Create(content::WebContents* web_contents,
+ SadTabKind kind,
+ SadTabClient* client);
sadrul 2014/09/22 16:48:22 This doesn't seem to exist/be necessary in this pa
// Returns true if the sad tab should be shown.
static bool ShouldShow(base::TerminationStatus status);
@@ -32,6 +36,6 @@ class SadTab {
virtual void Close() = 0;
};
-} // namespace chrome
+} // namespace sad_tab
-#endif // CHROME_BROWSER_UI_SAD_TAB_H_
+#endif // COMPONENTS_SAD_TAB_SAD_TAB_H_

Powered by Google App Engine
This is Rietveld 408576698