chrome/chrome_browser_ui.gypi - Issue 543663002: Componentize sad_tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 543663002: Componentize sad_tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index e4d8ba41f3614e5ed4b3a38d18b81a6329b2e0c0..4ac2600e57df78f6bde17e41e0310f56bf68e58a 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -1405,6 +1405,9 @@

'browser/ui/browser_view_prefs.h',

'browser/ui/chrome_pages.cc',

'browser/ui/chrome_pages.h',

+ 'browser/ui/chrome_sad_tab_client.cc',

+ 'browser/ui/chrome_sad_tab_client.h',

+ 'browser/ui/chrome_sad_tab_client_mac.mm',

'browser/ui/chrome_style.cc',

'browser/ui/chrome_style.h',

'browser/ui/chrome_web_modal_dialog_manager_delegate.cc',

@@ -1504,11 +1507,6 @@

'browser/ui/pdf/chrome_pdf_web_contents_helper_client.h',

'browser/ui/pdf/pdf_unsupported_feature.cc',

'browser/ui/pdf/pdf_unsupported_feature.h',

- 'browser/ui/sad_tab.cc',

- 'browser/ui/sad_tab.h',

- 'browser/ui/sad_tab_helper.cc',

- 'browser/ui/sad_tab_helper.h',

- 'browser/ui/sad_tab_types.h',

'browser/ui/search/search_delegate.cc',

'browser/ui/search/search_delegate.h',

'browser/ui/search/search_ui.cc',

@@ -2182,8 +2180,6 @@

'browser/ui/views/profiles/user_manager_view.h',

'browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc',

'browser/ui/views/renderer_context_menu/render_view_context_menu_views.h',

- 'browser/ui/views/sad_tab_view.cc',

- 'browser/ui/views/sad_tab_view.h',

'browser/ui/views/session_crashed_bubble_view.cc',

'browser/ui/views/session_crashed_bubble_view.h',

'browser/ui/views/settings_api_bubble_helper_views.cc',

@@ -2808,6 +2804,9 @@

'sources': [ '<@(chrome_browser_ui_android_sources)' ],

}, { # Non-Android

+ 'dependencies': [

+ '../components/components.gyp:sad_tab',

+ ],

'sources': [ '<@(chrome_browser_ui_non_android_sources)' ],

}],

['OS=="mac"', {

« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.cc ('k') | chrome/common/url_constants.h » ('j') | components/sad_tab/sad_tab.h » ('J')