Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54363008: move SkImage::ColorType into SkColorType (Closed)

Created:
7 years, 1 month ago by reed1
Modified:
7 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

move SkImage::ColorType into SkColorType objective -- move clients over to SkImage tasks - use SkImageInfo instead of SkBitmap::Config - add support for colortables to SkImage - add drawImage to SkCanvas - return SkImage from readPixels This CL works towards the first task R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -117 lines) Patch
M bench/DeferredSurfaceCopyBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M debugger/QT/SkImageWidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/image.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/srcmode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkImage.h View 2 chunks +35 lines, -20 lines 0 comments Download
M include/core/SkImageDecoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkSurface.h View 4 chunks +7 lines, -7 lines 0 comments Download
M include/lazy/SkBitmapFactory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M platform_tools/android/examples/hello_skia_app/jni/helloskia.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleFatBits.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/image/SkImagePriv.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkSurface_Picture.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkBitmapFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkLazyPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkLazyPixelRef.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DeferredCanvasTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/LazyDecodeBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 1 month ago (2013-11-01 13:22:06 UTC) #1
robertphillips
lgtm
7 years, 1 month ago (2013-11-01 13:36:54 UTC) #2
reed1
7 years, 1 month ago (2013-11-01 13:47:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r12077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698