Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: src/gpu/effects/GrGeometryProcessor.h

Issue 543623004: Removing vertex attrib indices (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: cleanup Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/effects/GrGeometryProcessor.h
diff --git a/src/gpu/effects/GrVertexEffect.h b/src/gpu/effects/GrGeometryProcessor.h
similarity index 68%
rename from src/gpu/effects/GrVertexEffect.h
rename to src/gpu/effects/GrGeometryProcessor.h
index 323c85e34e11501bc5260b0d0ad75b1ac38abb93..3d3bee6866529dd5a95752a9a3901c65e9ce8e5d 100644
--- a/src/gpu/effects/GrVertexEffect.h
+++ b/src/gpu/effects/GrGeometryProcessor.h
@@ -5,8 +5,8 @@
* found in the LICENSE file.
*/
-#ifndef GrVertexEffect_DEFINED
-#define GrVertexEffect_DEFINED
+#ifndef GrGeometryProcessor_DEFINED
+#define GrGeometryProcessor_DEFINED
#include "GrEffect.h"
@@ -15,9 +15,9 @@
* Otherwise it won't be able to add vertex attribs, and it might be given a vertexless shader
* program in emitCode.
*/
-class GrVertexEffect : public GrEffect {
+class GrGeometryProcessor : public GrEffect {
public:
- GrVertexEffect() { fRequiresVertexShader = true; }
+ GrGeometryProcessor() { fRequiresVertexShader = true; }
protected:
/**
@@ -25,9 +25,8 @@ protected:
* kMaxVertexAttribs). This must only be called from the constructor because GrEffects are
* immutable.
*/
- void addVertexAttrib(GrSLType type) {
- SkASSERT(fVertexAttribTypes.count() < kMaxVertexAttribs);
- fVertexAttribTypes.push_back(type);
+ void addVertexAttrib(const GrShaderVar& var) {
+ fVertexAttribs.push_back(var);
}
private:

Powered by Google App Engine
This is Rietveld 408576698