Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54353005: Fix sync_client to work with oauth2 tokens. (Closed)

Created:
7 years, 1 month ago by pavely
Modified:
7 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix sync_client to work with oauth2 tokens. When initializing invalidator pass parameter that says that token is OAuth2 access token. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233289

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/tools/sync_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pavely
7 years, 1 month ago (2013-11-01 22:29:58 UTC) #1
Nicolas Zea
LGTM
7 years, 1 month ago (2013-11-01 22:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/1
7 years, 1 month ago (2013-11-01 22:55:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217883
7 years, 1 month ago (2013-11-02 01:36:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/1
7 years, 1 month ago (2013-11-02 03:15:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217992
7 years, 1 month ago (2013-11-02 05:03:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/1
7 years, 1 month ago (2013-11-04 06:00:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97088
7 years, 1 month ago (2013-11-04 07:50:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/440001
7 years, 1 month ago (2013-11-04 16:13:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/440001
7 years, 1 month ago (2013-11-04 17:44:38 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218874
7 years, 1 month ago (2013-11-05 00:42:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/440001
7 years, 1 month ago (2013-11-05 16:29:51 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219802
7 years, 1 month ago (2013-11-05 23:13:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/54353005/440001
7 years, 1 month ago (2013-11-06 15:21:24 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 17:35:10 UTC) #15
Message was sent while issue was closed. 
Change committed as 233289

Powered by Google App Engine
This is Rietveld 408576698