Chromium Code Reviews Chromium Code Reviews
Issue 543493004:
New Test for 'vertical-align has no effect on a grid item' (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html |
| diff --git a/LayoutTests/fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html b/LayoutTests/fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..0a83312e1bce49030539d90c6b2a57c63de31a02 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html |
| @@ -0,0 +1,27 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<link href='resources/grid.css' rel='stylesheet'> |
| +<style> |
| +.grid { |
| + background-color:lightgrey; |
|
Julien - ping for review
2014/09/10 22:18:36
Nit: I like to put a space after the semi-colon li
Sunil Ratnu
2014/09/11 12:38:02
I've removed background-color in the latest patch.
Julien - ping for review
2014/09/11 18:24:20
I am fine with some colors to ease visual debuggin
|
| +} |
| + |
| +#item4 { |
|
Julien - ping for review
2014/09/10 22:18:37
With that declaration, only one grid item is actua
Sunil Ratnu
2014/09/11 12:38:02
Done.
|
| + vertical-align:20px; |
| +} |
| +</style> |
| + |
|
Julien - ping for review
2014/09/10 22:18:36
The test should state what it's testing (aka descr
Sunil Ratnu
2014/09/11 12:38:01
Done.
|
| +<div class='grid'> |
| + |
| + <!-- grid item: block child --> |
| + <div id='item1'>block</div> |
| + |
| + <!-- grid item: floated element; floating is ignored --> |
|
Julien - ping for review
2014/09/10 22:18:36
This seems like it's testing something unrelated t
Sunil Ratnu
2014/09/11 12:38:02
Removed "floating is ignored" but keeping the styl
Julien - ping for review
2014/09/11 18:24:20
What do you call increased test coverage? If float
|
| + <div id='item2' style='float: left;'>float</div> |
| + |
| + <!-- grid item: anonymous block box around inline content --> |
| + anonymous item 3 |
| + |
| + <!-- grid item: inline child --> |
| + <span id='item4'>item 4</span> |
| +</div> |
