chrome/browser/resources/options/website_settings.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/website_settings.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: fixed all but one comment (website_settings.js:42 left) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/options_page.js ('K') | « chrome/browser/resources/options/supervised_user_learn_more.js ('k') | chrome/browser/resources/options/website_settings_edit_page.js » ('j') | ui/webui/resources/js/cr/ui/bubble_button.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/website_settings.js

diff --git a/chrome/browser/resources/options/website_settings.js b/chrome/browser/resources/options/website_settings.js

index bcc1aa437aaaedae4f6022357f26d54d67ff3795..1aae97f3d987ac044fd72996552d93f750e86f90 100644

--- a/chrome/browser/resources/options/website_settings.js

+++ b/chrome/browser/resources/options/website_settings.js

@@ -13,6 +13,7 @@ cr.define('options', function() {

/**

* Encapsulated handling of the website settings page.

* @constructor

+ * @extends {cr.ui.pageManager.Page}

function WebsiteSettingsManager() {

Page.call(this, 'websiteSettings',

@@ -27,7 +28,7 @@ cr.define('options', function() {

/**

* The saved origins list.

- * @type {OriginList}

+ * @type {options.OriginList}

* @private

originList_: null,

@@ -39,7 +40,7 @@ cr.define('options', function() {

$('website-settings-overlay-confirm').onclick =

PageManager.closeOverlay.bind(PageManager);

- $('resourceType').onchange = function() {

+ $('resourceType').onchange = function(event) {

var target = event.target;

assert(target.tagName == 'SELECT');

if (target.value == 'storage')