chrome/browser/resources/options/chromeos/accounts_user_name_edit.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: fixed all but one comment (website_settings.js:42 left) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/chromeos/accounts_user_list.js ('k') | chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js » ('j') | chrome/browser/resources/options/chromeos/internet_detail.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

diff --git a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

index 88d2878d11f58bfa7c912f5418084eee327c21f6..f26a3b6d687b5092770793fa2fd102b8489f1f1c 100644

--- a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

+++ b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

@@ -67,7 +67,8 @@ cr.define('options.accounts', function() {

* more times in a row.)

* @param {string} str A string to parse.

- * @return {{name: string, email: string}} User info parsed from the string.

+ * @return {?{name: string, email: string}} User info parsed from the

+ * string.

parse: function(str) {

/** @const */ var format1 = new RegExp(format1String);