ui/webui/resources/js/cr/ui/position_util.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/position_util.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: rebase? rebase! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/position_util.js

diff --git a/ui/webui/resources/js/cr/ui/position_util.js b/ui/webui/resources/js/cr/ui/position_util.js

index 0f86bbf6c5449992d7266040ce942991863314c5..14b29d92d97b9d3d592255e0787d15c820979376 100644

--- a/ui/webui/resources/js/cr/ui/position_util.js

+++ b/ui/webui/resources/js/cr/ui/position_util.js

@@ -211,13 +211,14 @@ cr.define('cr.ui', function() {

* to.

* @param {!HTMLElement} popupElement The popup element we are positioning.

* @param {cr.ui.AnchorType} type The type of anchoring we want.

- * @param {boolean} invertLeftRight Whether to invert the right/left

+ * @param {boolean=} opt_invertLeftRight Whether to invert the right/left

* alignment.

function positionPopupAroundElement(anchorElement, popupElement, type,

- invertLeftRight) {

+ opt_invertLeftRight) {

var anchorRect = anchorElement.getBoundingClientRect();

- positionPopupAroundRect(anchorRect, popupElement, type, invertLeftRight);

+ positionPopupAroundRect(anchorRect, popupElement, type,

+ !!opt_invertLeftRight);

}

/**

« no previous file with comments | « ui/webui/resources/js/cr/ui/list_single_selection_model.js ('k') | ui/webui/resources/js/cr/ui/repeating_button.js » ('j') | no next file with comments »