chrome/browser/resources/options/search_page.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_page.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: rebase? rebase! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/search_engine_manager_engine_list.js ('k') | chrome/browser/resources/options/settings_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_page.js

diff --git a/chrome/browser/resources/options/search_page.js b/chrome/browser/resources/options/search_page.js

index 887a13af073c7713d66dc2c191f6acae8bd953a0..56ab10544cda45a1047dc8216c3108fcf5c4bf49 100644

--- a/chrome/browser/resources/options/search_page.js

+++ b/chrome/browser/resources/options/search_page.js

@@ -9,6 +9,7 @@ cr.define('options', function() {

/**

* Encapsulated handling of a search bubble.

* @constructor

+ * @extends {HTMLDivElement}

function SearchBubble(text) {

var el = cr.doc.createElement('div');

@@ -120,6 +121,7 @@ cr.define('options', function() {

/**

* Encapsulated handling of the search page.

* @constructor

+ * @extends {cr.ui.pageManager.Page}

function SearchPage() {

Page.call(this, 'search',

@@ -359,7 +361,7 @@ cr.define('options', function() {

$('searchPageNoMatches').hidden = foundMatches;

// Create search balloons for sub-page results.

- length = bubbleControls.length;

+ var length = bubbleControls.length;

for (var i = 0; i < length; i++)

this.createSearchBubble_(bubbleControls[i], text);