Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4370)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: rebase? rebase! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 98152ee15114d43318bb478a27841174c84286a1..c6c49ffa7e1ad04878e07d19cd6228acfa188fdb 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -124,14 +124,12 @@ cr.define('options', function() {
/**
* The name of the associated preference.
- * @type {string}
*/
cr.defineProperty(PrefInputElement, 'pref', cr.PropertyKind.ATTR);
/**
* The data type of the associated preference, only relevant for derived
* classes that support different data types.
- * @type {string}
*/
cr.defineProperty(PrefInputElement, 'dataType', cr.PropertyKind.ATTR);
@@ -140,20 +138,17 @@ cr.define('options', function() {
* in the settings UI immediately but are only actually committed when the
* user confirms the dialog. If the user cancels the dialog instead, the
* changes are rolled back in the settings UI and never committed.
- * @type {boolean}
*/
cr.defineProperty(PrefInputElement, 'dialogPref', cr.PropertyKind.BOOL_ATTR);
/**
* Whether the associated preference is controlled by a source other than the
* user's setting (can be 'policy', 'extension', 'recommended' or unset).
- * @type {string}
*/
cr.defineProperty(PrefInputElement, 'controlledBy', cr.PropertyKind.ATTR);
/**
* The user metric string.
- * @type {string}
*/
cr.defineProperty(PrefInputElement, 'metric', cr.PropertyKind.ATTR);
@@ -206,7 +201,6 @@ cr.define('options', function() {
/**
* Whether the mapping between checkbox state and associated pref is inverted.
- * @type {boolean}
*/
cr.defineProperty(PrefCheckbox, 'inverted_pref', cr.PropertyKind.BOOL_ATTR);
@@ -419,7 +413,7 @@ cr.define('options', function() {
// Make sure the value is a string, because the value is stored as a
// string in the HTMLOptionElement.
- value = String(event.value.value);
+ var value = String(event.value.value);
var found = false;
for (var i = 0; i < this.options.length; i++) {
@@ -561,14 +555,12 @@ cr.define('options', function() {
/**
* The name of the associated preference.
- * @type {string}
*/
cr.defineProperty(PrefButton, 'pref', cr.PropertyKind.ATTR);
/**
* Whether the associated preference is controlled by a source other than the
* user's setting (can be 'policy', 'extension', 'recommended' or unset).
- * @type {string}
*/
cr.defineProperty(PrefButton, 'controlledBy', cr.PropertyKind.ATTR);
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.js ('k') | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698