chrome/browser/resources/options/password_manager.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: rebase? rebase! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/origin_resources_list.js ('k') | chrome/browser/resources/options/password_manager_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/password_manager.js

diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js

index 4758254538cf243d93e99601941836210b30514d..8ad79a83ae69147105a2732eac7ff4efb82320c7 100644

--- a/chrome/browser/resources/options/password_manager.js

+++ b/chrome/browser/resources/options/password_manager.js

@@ -13,6 +13,7 @@ cr.define('options', function() {

/**

* Encapsulated handling of password and exceptions page.

* @constructor

+ * @extends {cr.ui.pageManager.Page}

function PasswordManager() {

this.activeNavTab = null;

@@ -28,14 +29,14 @@ cr.define('options', function() {

/**

* The saved passwords list.

- * @type {DeletableItemList}

+ * @type {options.DeletableItemList}

* @private

savedPasswordsList_: null,

/**

* The password exceptions list.

- * @type {DeletableItemList}

+ * @type {options.DeletableItemList}

* @private

passwordExceptionsList_: null,

@@ -138,7 +139,7 @@ cr.define('options', function() {

/**

* Updates the visibility of the list and empty list placeholder.

- * @param {!List} list The list to toggle visilibility for.

+ * @param {!cr.ui.List} list The list to toggle visilibility for.

updateListVisibility_: function(list) {

var empty = list.dataModel.length == 0;