chrome/browser/resources/options/hotword_search_setting_indicator.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/hotword_search_setting_indicator.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: rebase? rebase! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/handler_options_list.js ('k') | chrome/browser/resources/options/inline_editable_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/hotword_search_setting_indicator.js

diff --git a/chrome/browser/resources/options/hotword_search_setting_indicator.js b/chrome/browser/resources/options/hotword_search_setting_indicator.js

index 38dabea0f13ce9b7dd5a44d4d5f29f2b7cf7aae8..697e63f7b2187a594a6376adcb0308f996f9f1f4 100644

--- a/chrome/browser/resources/options/hotword_search_setting_indicator.js

+++ b/chrome/browser/resources/options/hotword_search_setting_indicator.js

@@ -11,7 +11,7 @@ cr.define('options', function() {

* of the hotword search setting, including a bubble to show setup errors

* (such as failures to download extension resources).

* @constructor

- * @extends {HTMLSpanElement}

+ * @extends {options.ControlledSettingIndicator}

var HotwordSearchSettingIndicator = cr.ui.define('span');

@@ -69,8 +69,9 @@ cr.define('options', function() {

* Toggles showing and hiding the error message bubble. An empty

* |errorText_| indicates that there is no error message. So the bubble

* only be shown if |errorText_| has a value.

+ * @override

- toggleBubble_: function() {

+ toggleBubble: function() {

if (this.showingBubble) {

PageManager.hideBubble();

return;