Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: chrome/browser/resources/options/editable_text_field.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: rebase? rebase! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/editable_text_field.js
diff --git a/chrome/browser/resources/options/editable_text_field.js b/chrome/browser/resources/options/editable_text_field.js
index 8c5787249ccb2a12f257c3e6d31d71644391e743..c1f51a6892552f347680e1a46d24a73827f42c80 100644
--- a/chrome/browser/resources/options/editable_text_field.js
+++ b/chrome/browser/resources/options/editable_text_field.js
@@ -3,6 +3,10 @@
// found in the LICENSE file.
cr.define('options', function() {
+ /**
+ * @constructor
+ * @extends {HTMLDivElement}
+ */
var EditableTextField = cr.ui.define('div');
/**
@@ -50,7 +54,7 @@ cr.define('options', function() {
decorate: function() {
this.classList.add('editable-text-field');
- this.createEditableTextCell();
+ this.createEditableTextCell('');
if (this.hasAttribute('i18n-placeholder-text')) {
var identifier = this.getAttribute('i18n-placeholder-text');
@@ -227,14 +231,16 @@ cr.define('options', function() {
var container = this.ownerDocument.createElement('div');
- var textEl = this.ownerDocument.createElement('div');
+ var textEl = /** @type {HTMLElement} */(
+ this.ownerDocument.createElement('div'));
textEl.className = 'static-text';
textEl.textContent = text;
textEl.setAttribute('displaymode', 'static');
this.appendChild(textEl);
this.staticText_ = textEl;
- var inputEl = this.ownerDocument.createElement('input');
+ var inputEl = /** @type {HTMLElement} */(
+ this.ownerDocument.createElement('input'));
inputEl.className = 'editable-text';
inputEl.type = 'text';
inputEl.value = text;
« no previous file with comments | « chrome/browser/resources/options/deletable_item_list.js ('k') | chrome/browser/resources/options/font_settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698