chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/password_manager.js ('K') | « chrome/browser/resources/options/search_engine_manager.js ('k') | chrome/browser/resources/options/search_page.js » ('j') | chrome/browser/resources/options/website_settings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index d81258eedcd3ccf8286cdb91914af57aaa00ce7f..04a6eeee90278ba6c759f200004aec3a24b2ee4b 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -180,7 +180,7 @@ cr.define('options.search_engines', function() {

} else {

this.editable = false;

this.querySelector('.row-delete-button').hidden = true;

- var indicator = ControlledSettingIndicator();

+ var indicator = new ControlledSettingIndicator();

indicator.setAttribute('setting', 'search-engine');

// Create a synthetic pref change event decorated as

// CoreOptionsHandler::CreateValueForPref() does.

@@ -248,7 +248,7 @@ cr.define('options.search_engines', function() {

* Returns the input field values as an array suitable for passing to

* chrome.send. The order of the array is important.

* @private

- * @return {array} The current input field values.

+ * @return {Array} The current input field values.

getInputFieldValues_: function() {

return [this.nameField_.value,