chrome/browser/resources/options/options_page.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/manage_profile_overlay.js ('K') | « chrome/browser/resources/options/manage_profile_overlay.js ('k') | chrome/browser/resources/options/origin_resources_list.js » ('j') | chrome/browser/resources/options/password_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options_page.js

diff --git a/chrome/browser/resources/options/options_page.js b/chrome/browser/resources/options/options_page.js

index b5fedb22dc5223d4b8665b2a54ffc6c784d1857f..7b3b5639aa7e597cd9b5b0ffc499c568e1693609 100644

--- a/chrome/browser/resources/options/options_page.js

+++ b/chrome/browser/resources/options/options_page.js

@@ -4,7 +4,6 @@

cr.define('options', function() {

/** @const */ var FocusOutlineManager = cr.ui.FocusOutlineManager;

- /** @const */ var PageManager = cr.ui.pageManager.PageManager;

var OptionsPage = {

/**

@@ -24,14 +23,14 @@ cr.define('options', function() {

/**

* Shows the tab contents for the given navigation tab.

- * @param {!Element} tab The tab that the user clicked.

+ * @param {Element} tab The tab that the user clicked.

showTab: function(tab) {

// Search parents until we find a tab, or the nav bar itself. This allows

// tabs to have child nodes, e.g. labels in separately-styled spans.

while (tab && !tab.classList.contains('subpages-nav-tabs') &&

Dan Beam 2014/09/06 02:22:36 maybe add a check for tab.classList here?

Vitaly Pavlenko 2014/09/06 22:54:08 Why do we need to? I think classList is present in

Dan Beam 2014/09/09 02:59:09 document.documentElement.parentNode.classList is u

Vitaly Pavlenko 2014/09/09 17:54:51 Done.

!tab.classList.contains('tab')) {

- tab = tab.parentNode;

+ tab = /** @type {Element} */(tab.parentNode);

}

if (!tab || !tab.classList.contains('tab'))

return;