Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2100)

Unified Diff: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
diff --git a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
index 88d2878d11f58bfa7c912f5418084eee327c21f6..f26a3b6d687b5092770793fa2fd102b8489f1f1c 100644
--- a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
+++ b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
@@ -67,7 +67,8 @@ cr.define('options.accounts', function() {
* more times in a row.)
*
* @param {string} str A string to parse.
- * @return {{name: string, email: string}} User info parsed from the string.
+ * @return {?{name: string, email: string}} User info parsed from the
Dan Beam 2014/09/06 02:22:36 isn't this the default?
Vitaly Pavlenko 2014/09/06 22:54:07 No. https://gist.github.com/vpavlenko/45226ac2e387
Dan Beam 2014/09/09 02:59:09 the literal notation ({key: type}) is non-nullable
Vitaly Pavlenko 2014/09/09 17:54:51 Acknowledged.
+ * string.
*/
parse: function(str) {
/** @const */ var format1 = new RegExp(format1String);

Powered by Google App Engine
This is Rietveld 408576698