Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManageProfileOverlay class
    * Encapsulated handling of the 'Manage profile...' overlay page.
    * @constructor
-   * @class
+   * @extends {cr.ui.pageManager.Page}
    */
   function ManageProfileOverlay() {
     Page.call(this, 'manageProfile',
               loadTimeData.getString('manageProfileTabTitle'),
               'manage-profile-overlay');
   };
 
   cr.addSingletonGetter(ManageProfileOverlay);
 
   ManageProfileOverlay.prototype = {
@@ skipping 320 matching lines @@
      * accordingly.
      * @private
      */
     requestExistingSupervisedUsers_: function() {
       options.SupervisedUserListData.requestExistingSupervisedUsers().then(
           this.receiveExistingSupervisedUsers_.bind(this),
           this.onSigninError_.bind(this));
     },
 
     /**
+     * @param {Object} supervisedUser
+     * @param {boolean} nameIsUnique
+     */
+    getImportHandler_: function(supervisedUser, nameIsUnique) {
+      return function() {
+        if (supervisedUser.needAvatar || !nameIsUnique) {
+          PageManager.showPageByName('supervisedUserImport');
+        } else {
+          this.hideErrorBubble_('create');
+          CreateProfileOverlay.updateCreateInProgress(true);
+          chrome.send('createProfile',
+              [supervisedUser.name, supervisedUser.iconURL, false, true,
+                   supervisedUser.id]);
+        }
+      }

[Dan Beam, 2014/09/09 19:05:48]

}.bind(this);

+    },
+
+    /**
      * Callback which receives the list of existing supervised users. Checks if
      * the currently entered name is the name of an already existing supervised
      * user. If yes, the user is prompted to import the existing supervised
      * user, and the create button is disabled.
      * If the received list is empty, hides the "import" link.
      * @param {Array.<Object>} supervisedUsers The list of existing supervised
      *     users.
      * @private
      */
     receiveExistingSupervisedUsers_: function(supervisedUsers) {
@@ skipping 14 matching lines @@
 
           // Check if another supervised user also exists with that name.
           var nameIsUnique = true;
           var j;
           for (j = i + 1; j < supervisedUsers.length; ++j) {
             if (supervisedUsers[j].name == newName) {
               nameIsUnique = false;
               break;
             }
           }
-          var self = this;
-          function getImportHandler(supervisedUser, nameIsUnique) {
-            return function() {
-              if (supervisedUser.needAvatar || !nameIsUnique) {
-                PageManager.showPageByName('supervisedUserImport');
-              } else {
-                self.hideErrorBubble_('create');
-                CreateProfileOverlay.updateCreateInProgress(true);
-                chrome.send('createProfile',
-                    [supervisedUser.name, supervisedUser.iconURL, false, true,
-                         supervisedUser.id]);
-              }
-            }
-          };
           $('supervised-user-import-existing').onclick =
-              getImportHandler(supervisedUsers[i], nameIsUnique);
+              this.getImportHandler_(supervisedUsers[i], nameIsUnique)
+                  .bind(this);

[Dan Beam, 2014/09/09 19:05:48]

move bind() to getImportHandler_();

[Vitaly Pavlenko, 2014/09/09 21:26:05]

Done.

           $('create-profile-ok').disabled = true;
           return;
         }
       }
     },
 
     /**
      * Called in case the request for the list of supervised users fails because
      * of a signin error.
      * @private
@@ skipping 448 matching lines @@
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });