Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/chromeos/network_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.network', function() {
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var List = cr.ui.List;
   var ListItem = cr.ui.ListItem;
   var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
   var Menu = cr.ui.Menu;
@@ skipping 87 matching lines @@
     if (data.Type == 'Ethernet')
       return loadTimeData.getString('ethernetName');
     return data.Name;
   }
 
   /**
    * Create an element in the network list for controlling network
    * connectivity.
    * @param {Object} data Description of the network list or command.
    * @constructor
+   * @extends {cr.ui.ListItem}
    */
   function NetworkListItem(data) {
     var el = cr.doc.createElement('li');
     el.data_ = {};
     for (var key in data)
       el.data_[key] = data[key];
     NetworkListItem.decorate(el);
     return el;
   }
 
@@ skipping 137 matching lines @@
       textContent.appendChild(categoryLabel);
       this.subtitle_ = this.ownerDocument.createElement('div');
       this.subtitle_.className = 'network-subtitle';
       textContent.appendChild(this.subtitle_);
     },
   };
 
   /**
    * Creates a control that displays a popup menu when clicked.
    * @param {Object} data  Description of the control.
+   * @constructor
+   * @extends {NetworkListItem}
    */
   function NetworkMenuItem(data) {
     var el = new NetworkListItem(data);
     el.__proto__ = NetworkMenuItem.prototype;
     el.decorate();
     return el;
   }
 
   NetworkMenuItem.prototype = {
     __proto__: NetworkListItem.prototype,
@@ skipping 84 matching lines @@
         this.menu_.hidden = false;
       }
       if (rescan)
         chrome.send('refreshNetworks');
     },
   };
 
   /**
    * Creates a control for selecting or configuring a network connection based
    * on the type of connection (e.g. wifi versus vpn).
-   * @param {Object} data Description of the network.
-   * @param {string} data.key Item key.
-   * @param {Array.<Object>} data.networkList Description of the network.
+   * @param {{key: string, networkList: Array.<Object>}} data Description of the
+   *     network.
    * @constructor
+   * @extends {NetworkMenuItem}
    */
   function NetworkSelectorItem(data) {
     var el = new NetworkMenuItem(data);
     el.__proto__ = NetworkSelectorItem.prototype;
     el.decorate();
     return el;
   }
 
   NetworkSelectorItem.prototype = {
     __proto__: NetworkMenuItem.prototype,
@@ skipping 39 matching lines @@
         // is deferred in order to ensure that position of this element has
         // beem properly updated.
         var self = this;
         setTimeout(function() {self.showMenu();}, 0);
       }
     },
 
     /**
      * Creates a menu for selecting, configuring or disconnecting from a
      * network.
-     * @return {Element} The newly created menu.
+     * @return {!Element} The newly created menu.
      */
     createMenu: function() {
       var menu = this.ownerDocument.createElement('div');
       menu.id = this.getMenuName();
       menu.className = 'network-menu';
       menu.hidden = true;
       Menu.decorate(menu);
       var addendum = [];
       if (this.data_.key == 'WiFi') {
         addendum.push({label: loadTimeData.getString('joinOtherNetwork'),
@@ skipping 208 matching lines @@
           data.ConnectionState == 'Connecting') {
         var label = menuItem.getElementsByClassName(
             'network-menu-item-label')[0];
         label.classList.add('active-network');
       }
     }
   };
 
   /**
    * Creates a button-like control for configurating internet connectivity.
-   * @param {Object} data Description of the network control.
-   * @param {string} data.key Item key.
-   * @param {string} data.subtitle Subtitle.
-   * @param {function} data.command Item callback.
+   * @param {{key: string, subtitle: string, command: Function}} data
+   *     Description of the network control.
    * @constructor
+   * @extends {NetworkListItem}
    */
   function NetworkButtonItem(data) {
     var el = new NetworkListItem(data);
     el.__proto__ = NetworkButtonItem.prototype;
     el.decorate();
     return el;
   }
 
   NetworkButtonItem.prototype = {
     __proto__: NetworkListItem.prototype,
@@ skipping 13 matching lines @@
       if (this.data.policyManaged)
         this.showManagedNetworkIndicator();
     },
   };
 
   /**
    * Adds a command to a menu for modifying network settings.
    * @param {!Element} menu Parent menu.
    * @param {!Object} data Description of the network.
    * @param {!string} label Display name for the menu item.
-   * @param {?(string|function)} command Callback function or name
+   * @param {?(string|!Function)} command Callback function or name
    *     of the command for |networkCommand|.
-   * @param {?string=} opt_iconURL Optional URL to an icon for the menu item.
+   * @param {string=} opt_iconURL Optional URL to an icon for the menu item.
    * @return {!Element} The created menu item.
    * @private
    */
   function createCallback_(menu, data, label, command, opt_iconURL) {
     var button = menu.ownerDocument.createElement('div');
     button.className = 'network-menu-item';
 
     var buttonIcon = menu.ownerDocument.createElement('div');
     buttonIcon.className = 'network-menu-item-icon';
     button.appendChild(buttonIcon);
     if (opt_iconURL)
       buttonIcon.style.backgroundImage = url(opt_iconURL);
 
     var buttonLabel = menu.ownerDocument.createElement('span');
     buttonLabel.className = 'network-menu-item-label';
     buttonLabel.textContent = label;
     button.appendChild(buttonLabel);
     var callback = null;
     if (typeof command == 'string') {
       var type = data.Type;
       var path = data.servicePath;
       callback = function() {
         chrome.send('networkCommand',
                     [type, path, command]);
         closeMenu_();
       };
     } else if (command != null) {
       if (data) {
         callback = function() {
-          command(data);
+          (/** @type {Function} */(command))(data);
           closeMenu_();
         };
       } else {
         callback = function() {
-          command();
+          (/** @type {Function} */(command))();
           closeMenu_();
         };
       }
     }
     if (callback != null)
       button.addEventListener('click', callback);
     else
       buttonLabel.classList.add('network-disabled-control');
 
     button.data = {label: label};
     MenuItem.decorate(button);
     menu.appendChild(button);
     return button;
   }
 
   /**
    * A list of controls for manipulating network connectivity.
    * @constructor
+   * @extends {cr.ui.List}
    */
   var NetworkList = cr.ui.define('list');
 
   NetworkList.prototype = {
     __proto__: List.prototype,
 
     /** @override */
     decorate: function() {
       List.prototype.decorate.call(this);
       this.startBatchUpdates();
@@ skipping 58 matching lines @@
             }
           }
         }
       }
     },
 
     /**
      * Finds the index of a network item within the data model based on
      * category.
      * @param {string} key Unique key for the item in the list.
-     * @return {number} The index of the network item, or |undefined| if it is
-     *     not found.
+     * @return {(number|undefined)} The index of the network item, or
+     *     |undefined| if it is not found.
      */
     indexOf: function(key) {
       var size = this.dataModel.length;
       for (var i = 0; i < size; i++) {
         var entry = this.dataModel.item(i);
         if (entry.key == key)
           return i;
       }
       return undefined;
     },
@@ skipping 169 matching lines @@
     var networkList = $('network-list');
     networkList.update({key: name,
                         subtitle: subtitle,
                         iconType: icon,
                         command: enableNetwork});
   }
 
   /**
    * Element for indicating a policy managed network.
    * @constructor
+   * @extends {options.ControlledSettingIndicator}
    */
   function ManagedNetworkIndicator() {
     var el = cr.doc.createElement('span');
     el.__proto__ = ManagedNetworkIndicator.prototype;
     el.decorate();
     return el;
   }
 
   ManagedNetworkIndicator.prototype = {
     __proto__: ControlledSettingIndicator.prototype,
@@ skipping 20 matching lines @@
      * that would close any currently open menu and preventing propagation to
      * any elements located behind the bubble.
      * @param {Event} event Mouse event.
      */
     stopEvent: function(event) {
       event.preventDefault();
       event.stopPropagation();
     },
 
     /** @override */
-    toggleBubble_: function() {
+    toggleBubble: function() {
       if (activeMenu_ && !$(activeMenu_).contains(this))
         closeMenu_();
-      ControlledSettingIndicator.prototype.toggleBubble_.call(this);
+      ControlledSettingIndicator.prototype.toggleBubble.call(this);
       if (this.showingBubble) {
         var bubble = PageManager.getVisibleBubble();
         bubble.addEventListener('mousedown', this.stopEvent);
         bubble.addEventListener('click', this.stopEvent);
       }
     }
   };
 
   /**
    * Updates the list of available networks and their status, filtered by
@@ skipping 69 matching lines @@
    * Whether the Network list is disabled. Only used for display purpose.
    * @type {boolean}
    */
   cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   // Export
   return {
     NetworkList: NetworkList
   };
 });