Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/chromeos/user_images_grid.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var Grid = cr.ui.Grid;
   /** @const */ var GridItem = cr.ui.GridItem;
   /** @const */ var GridSelectionController = cr.ui.GridSelectionController;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
    /**
     * Dimensions for camera capture.
     * @const
     */
   var CAPTURE_SIZE = {
     height: 480,
     width: 480
   };
 
   /**
    * Path for internal URLs.
    * @const
    */
   var CHROME_THEME_PATH = 'chrome://theme';
 
   /**
    * Creates a new user images grid item.
-   * @param {{url: string, title: string=, decorateFn: function=,
-   *     clickHandler: function=}} imageInfo User image URL, optional title,
-   *     decorator callback and click handler.
+   * @param {{url: string, title: (string|undefined),
+   *     decorateFn: (!Function|undefined),
+   *     clickHandler: (!Function|undefined)}} imageInfo User image URL,
+   *     optional title, decorator callback and click handler.
    * @constructor
    * @extends {cr.ui.GridItem}
    */
   function UserImagesGridItem(imageInfo) {
     var el = new GridItem(imageInfo);
     el.__proto__ = UserImagesGridItem.prototype;
     return el;
   }
 
   UserImagesGridItem.prototype = {
@@ skipping 192 matching lines @@
       if (this.cameraStream_)
         this.cameraStream_.stop();
       // Cancel any pending getUserMedia() checks.
       this.cameraStartInProgress_ = false;
     },
 
     /**
      * Handles successful camera check.
      * @param {function(): boolean} onAvailable Callback to call. If it returns
      *     |true|, capture is started immediately.
-     * @param {MediaStream} stream Stream object as returned by getUserMedia.
+     * @param {!MediaStream} stream Stream object as returned by getUserMedia.
      * @private
      */
     handleCameraAvailable_: function(onAvailable, stream) {
       if (this.cameraStartInProgress_ && onAvailable()) {
         this.cameraVideo_.src = URL.createObjectURL(stream);
         this.cameraStream_ = stream;
       } else {
         stream.stop();
       }
       this.cameraStartInProgress_ = false;
@@ skipping 50 matching lines @@
           $('user-image-grid').focus();
         }
       };
       // Timeout guarantees processing AFTER style changes display attribute.
       setTimeout(setFocusIfLost, 0);
     },
 
     /**
      * Current image captured from camera as data URL. Setting to null will
      * return to the live camera stream.
-     * @type {string=}
+     * @type {(string|undefined)}
      */
     get cameraImage() {
       return this.cameraImage_;
     },
     set cameraImage(imageUrl) {
       this.cameraLive = !imageUrl;
       if (this.cameraPresent && !imageUrl)
         imageUrl = UserImagesGrid.ButtonImages.TAKE_PHOTO;
       if (imageUrl) {
         this.cameraImage_ = this.cameraImage_ ?
@@ skipping 127 matching lines @@
 
     /**
      * Performs photo capture from the live camera stream. 'phototaken' event
      * will be fired as soon as captured photo is available, with 'dataURL'
      * property containing the photo encoded as a data URL.
      * @return {boolean} Whether photo capture was successful.
      */
     takePhoto: function() {
       if (!this.cameraOnline)
         return false;
-      var canvas = document.createElement('canvas');
+      var canvas = /** @type {HTMLCanvasElement} */(
+          document.createElement('canvas'));
       canvas.width = CAPTURE_SIZE.width;
       canvas.height = CAPTURE_SIZE.height;
       this.captureFrame_(
           this.cameraVideo_, canvas.getContext('2d'), CAPTURE_SIZE);
       // Preload image before displaying it.
       var previewImg = new Image();
       previewImg.addEventListener('load', function(e) {
         this.cameraTitle_ = this.capturedImageTitle_;
         this.cameraImage = previewImg.src;
       }.bind(this));
@@ skipping 110 matching lines @@
       var imageIndex = this.indexOf(imageInfo);
       var wasSelected = this.selectionModel.selectedIndex == imageIndex;
       this.removeItem(imageInfo);
       var newInfo = this.addItem(
           imageUrl,
           opt_title === undefined ? imageInfo.title : opt_title,
           imageInfo.clickHandler,
           imageIndex,
           imageInfo.decorateFn);
       // Update image data with the reset of the keys from the old data.
-      for (k in imageInfo) {
+      for (var k in imageInfo) {
         if (!(k in newInfo))
           newInfo[k] = imageInfo[k];
       }
       if (wasSelected)
         this.selectedItem = newInfo;
       return newInfo;
     },
 
     /**
      * Removes previously added image from the grid.
@@ skipping 33 matching lines @@
   UserImagesGrid.ButtonImages = {
     TAKE_PHOTO: 'chrome://theme/IDR_BUTTON_USER_IMAGE_TAKE_PHOTO',
     CHOOSE_FILE: 'chrome://theme/IDR_BUTTON_USER_IMAGE_CHOOSE_FILE',
     PROFILE_PICTURE: 'chrome://theme/IDR_PROFILE_PICTURE_LOADING'
   };
 
   return {
     UserImagesGrid: UserImagesGrid
   };
 });