Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+cr.exportPath('options');
+
+/**
+ * The user's selection in the synced data type drop-down menu, as an index.
+ * @enum {number}
+ * @const
+ */
+options.DataTypeSelection = {
+  SYNC_EVERYTHING: 0,
+  CHOOSE_WHAT_TO_SYNC: 1,
+  SYNC_NOTHING: 2
+};
+
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
 
   // True if the synced account uses a custom passphrase.
   var usePassphrase_ = false;
 
   // True if the synced account uses 'encrypt everything'.
   var useEncryptEverything_ = false;
 
@@ skipping 17 matching lines @@
   // Initialized when the advanced settings dialog is first brought up, and
   // reset when the dialog is closed.
   var dataTypeBoxesDisabled_ = {};
 
   // Used to determine whether to bring the OK button / passphrase field into
   // focus.
   var confirmPageVisible_ = false;
   var customizePageVisible_ = false;
 
   /**
-   * The user's selection in the synced data type drop-down menu, as an index.
-   * @enum {number}
-   * @const
-   */
-  var DataTypeSelection = {
-    SYNC_EVERYTHING: 0,
-    CHOOSE_WHAT_TO_SYNC: 1,
-    SYNC_NOTHING: 2
-  };
-
-  /**
    * SyncSetupOverlay class
    * Encapsulated handling of the 'Sync Setup' overlay page.
    * @class
    */
   function SyncSetupOverlay() {
     Page.call(this, 'syncSetup',
               loadTimeData.getString('syncSetupOverlayTabTitle'),
               'sync-setup-overlay');
   }
 
@@ skipping 92 matching lines @@
      * advanced sync settings dialog. Called when "Choose what to sync" is
      * selected. Required because all the checkboxes are checked when
      * "Sync everything" is selected, and unchecked when "Sync nothing" is
      * selected. Note: We only restore checkboxes for data types that are
      * actually visible and whose old values are found in the cache, since it's
      * possible for some data types to not be registered, and therefore, their
      * checkboxes remain hidden, and never get cached.
      * @private
      */
     restoreDataTypeCheckboxes_: function() {
-      for (dataType in dataTypeBoxesChecked_) {
+      for (var dataType in dataTypeBoxesChecked_) {
         $(dataType).checked = dataTypeBoxesChecked_[dataType];
       }
     },
 
     /**
      * Enables / grays out the sync data type checkboxes in the advanced
      * settings dialog.
      * @param {boolean} enabled True for enabled, false for grayed out.
      * @private
      */
     setDataTypeCheckboxesEnabled_: function(enabled) {
       for (dataType in dataTypeBoxesDisabled_) {
         $(dataType).disabled = !enabled || dataTypeBoxesDisabled_[dataType];
       }
     },
 
     /**
      * Sets the state of the sync data type checkboxes based on whether "Sync
      * everything", "Choose what to sync", or "Sync nothing" are selected in the
      * drop-down menu of the advanced settings dialog.
-     * @param {cr.DataTypeSelection} selectedIndex Index of user's selection.
+     * @param {options.DataTypeSelection} selectedIndex Index of user's
+     *     selection.
      * @private
      */
     setDataTypeCheckboxes_: function(selectedIndex) {
-      if (selectedIndex == DataTypeSelection.CHOOSE_WHAT_TO_SYNC) {
+      if (selectedIndex == options.DataTypeSelection.CHOOSE_WHAT_TO_SYNC) {
         this.setDataTypeCheckboxesEnabled_(true);
         this.restoreDataTypeCheckboxes_();
       } else {
         this.setDataTypeCheckboxesEnabled_(false);
-        this.checkAllDataTypeCheckboxes_(selectedIndex ==
-                                         DataTypeSelection.SYNC_EVERYTHING);
+        this.checkAllDataTypeCheckboxes_(
+            selectedIndex == options.DataTypeSelection.SYNC_EVERYTHING);
       }
     },
 
     checkPassphraseMatch_: function() {
       var emptyError = $('empty-error');
       var mismatchError = $('mismatch-error');
       emptyError.hidden = true;
       mismatchError.hidden = true;
 
       var f = $('choose-data-types-form');
@@ skipping 50 matching lines @@
       // Don't allow the user to tweak the settings once we send the
       // configuration to the backend.
       this.setInputElementsDisabledState_(true);
       $('use-default-link').hidden = true;
       $('use-default-link').disabled = true;
       $('use-default-link').onclick = null;
 
       // These values need to be kept in sync with where they are read in
       // SyncSetupFlow::GetDataTypeChoiceData().
       var syncAll = $('sync-select-datatypes').selectedIndex ==
-                    DataTypeSelection.SYNC_EVERYTHING;
+                    options.DataTypeSelection.SYNC_EVERYTHING;
       var syncNothing = $('sync-select-datatypes').selectedIndex ==
-                        DataTypeSelection.SYNC_NOTHING;
+                        options.DataTypeSelection.SYNC_NOTHING;
       var result = JSON.stringify({
         'syncAllDataTypes': syncAll,
         'syncNothing': syncNothing,
         'bookmarksSynced': syncAll || $('bookmarks-checkbox').checked,
         'preferencesSynced': syncAll || $('preferences-checkbox').checked,
         'themesSynced': syncAll || $('themes-checkbox').checked,
         'passwordsSynced': syncAll || $('passwords-checkbox').checked,
         'autofillSynced': syncAll || $('autofill-checkbox').checked,
         'extensionsSynced': syncAll || $('extensions-checkbox').checked,
         'typedUrlsSynced': syncAll || $('typed-urls-checkbox').checked,
@@ skipping 20 matching lines @@
       var configureElements =
           $('customize-sync-preferences').querySelectorAll('input');
       for (var i = 0; i < configureElements.length; i++)
         configureElements[i].disabled = disabled;
       $('sync-select-datatypes').disabled = disabled;
 
       $('customize-link').hidden = disabled;
       $('customize-link').disabled = disabled;
       $('customize-link').onclick = disabled ? null : function() {
         SyncSetupOverlay.showCustomizePage(self.syncConfigureArgs_,
-                                           DataTypeSelection.SYNC_EVERYTHING);
+            options.DataTypeSelection.SYNC_EVERYTHING);
         return false;
       };
     },
 
     /**
      * Shows or hides the sync data type checkboxes in the advanced sync
      * settings dialog. Also initializes |dataTypeBoxesChecked_| and
      * |dataTypeBoxedDisabled_| with their values, and makes their onclick
      * handlers update |dataTypeBoxesChecked_|.
      * @param {Object} args The configuration data used to show/hide UI.
      * @private
      */
     setChooseDataTypesCheckboxes_: function(args) {
       var datatypeSelect = $('sync-select-datatypes');
       datatypeSelect.selectedIndex = args.syncAllDataTypes ?
-                                         DataTypeSelection.SYNC_EVERYTHING :
-                                         DataTypeSelection.CHOOSE_WHAT_TO_SYNC;
+          options.DataTypeSelection.SYNC_EVERYTHING :
+          options.DataTypeSelection.CHOOSE_WHAT_TO_SYNC;
 
       $('bookmarks-checkbox').checked = args.bookmarksSynced;
       dataTypeBoxesChecked_['bookmarks-checkbox'] = args.bookmarksSynced;
       dataTypeBoxesDisabled_['bookmarks-checkbox'] = args.bookmarksEnforced;
       $('bookmarks-checkbox').onclick = this.handleDataTypeClick_;
 
       $('preferences-checkbox').checked = args.preferencesSynced;
       dataTypeBoxesChecked_['preferences-checkbox'] = args.preferencesSynced;
       dataTypeBoxesDisabled_['preferences-checkbox'] = args.preferencesEnforced;
       $('preferences-checkbox').onclick = this.handleDataTypeClick_;
@@ skipping 105 matching lines @@
       // Once the advanced sync settings dialog is visible, we transition
       // between its drop-down menu items as follows:
       // "Sync everything": Show encryption and passphrase sections, and disable
       // and check all data type checkboxes.
       // "Sync nothing": Hide encryption and passphrase sections, and disable
       // and uncheck all data type checkboxes.
       // "Choose what to sync": Show encryption and passphrase sections, enable
       // data type checkboxes, and restore their checked state to the last time
       // the "Choose what to sync" was selected while the dialog was still up.
       datatypeSelect.onchange = function() {
-        if (this.selectedIndex == DataTypeSelection.SYNC_NOTHING) {
+        if (this.selectedIndex == options.DataTypeSelection.SYNC_NOTHING) {
           self.showSyncNothingPage_();
         } else {
           self.showCustomizePage_(self.syncConfigureArgs_, this.selectedIndex);
-          if (this.selectedIndex == DataTypeSelection.SYNC_EVERYTHING)
+          if (this.selectedIndex == options.DataTypeSelection.SYNC_EVERYTHING)
             self.checkAllDataTypeCheckboxes_(true);
           else
             self.restoreDataTypeCheckboxes_();
         }
       };
 
       this.resetPage_('sync-setup-configure');
       $('sync-setup-configure').hidden = false;
 
       // onsubmit is changed when submitting a passphrase. Reset it to its
       // default.
       $('choose-data-types-form').onsubmit = function() {
         self.sendConfiguration_();
         return false;
       };
 
       if (args) {
         this.setCheckboxesAndErrors_(args);
 
         this.useEncryptEverything_ = args.encryptAllData;
 
         // Determine whether to display the 'OK, sync everything' confirmation
         // dialog or the advanced sync settings dialog, and assign focus to the
         // OK button, or to the passphrase field if a passphrase is required.
         this.usePassphrase_ = args.usePassphrase;
         if (args.showSyncEverythingPage == false || this.usePassphrase_ ||
             args.syncAllDataTypes == false || args.showPassphrase) {
           var index = args.syncAllDataTypes ?
-                          DataTypeSelection.SYNC_EVERYTHING :
-                          DataTypeSelection.CHOOSE_WHAT_TO_SYNC;
+                          options.DataTypeSelection.SYNC_EVERYTHING :
+                          options.DataTypeSelection.CHOOSE_WHAT_TO_SYNC;
           this.showCustomizePage_(args, index);
         } else {
           this.showSyncEverythingPage_();
         }
       }
     },
 
     showSpinner_: function() {
       this.resetPage_('sync-setup-spinner');
       $('sync-setup-spinner').hidden = false;
@@ skipping 13 matching lines @@
       this.confirmPageVisible_ = true;
       this.customizePageVisible_ = false;
 
       $('confirm-sync-preferences').hidden = false;
       $('customize-sync-preferences').hidden = true;
 
       // Reset the selection to 'Sync everything'.
       $('sync-select-datatypes').selectedIndex = 0;
 
       // The default state is to sync everything.
-      this.setDataTypeCheckboxes_(DataTypeSelection.SYNC_EVERYTHING);
+      this.setDataTypeCheckboxes_(options.DataTypeSelection.SYNC_EVERYTHING);
 
       if (!this.usePassphrase_)
         $('sync-custom-passphrase').hidden = true;
 
       if (!this.useEncryptEverything_ && !this.usePassphrase_)
         $('basic-encryption-option').checked = true;
 
       // Give the OK button focus only when the dialog wasn't already visible.
       if (wasConfirmPageHidden)
         $('confirm-everything-ok').focus();
     },
 
     /**
      * Reveals the UI for when the user chooses not to sync any data types.
      * This happens when the user signs in and selects "Sync nothing" in the
      * advanced sync settings dialog.
      * @private
      */
     showSyncNothingPage_: function() {
       // Reset the selection to 'Sync nothing'.
-      $('sync-select-datatypes').selectedIndex = DataTypeSelection.SYNC_NOTHING;
+      $('sync-select-datatypes').selectedIndex =
+          options.DataTypeSelection.SYNC_NOTHING;
 
       // Uncheck and disable the individual data type checkboxes.
       this.checkAllDataTypeCheckboxes_(false);
       this.setDataTypeCheckboxesEnabled_(false);
 
       // Hide the encryption section.
       $('customize-sync-encryption-new').hidden = true;
       $('sync-custom-passphrase-container').hidden = true;
       $('sync-existing-passphrase-container').hidden = true;
 
@@ skipping 39 matching lines @@
       // previously but failed).
       $('incorrect-passphrase').hidden =
           !(args.usePassphrase && args.passphraseFailed);
 
       $('sync-passphrase-warning').hidden = false;
     },
 
     /**
      * Displays the advanced sync setting dialog, and pre-selects either the
      * "Sync everything" or the "Choose what to sync" drop-down menu item.
-     * @param {cr.DataTypeSelection} index Index of item to pre-select.
+     * @param {options.DataTypeSelection} index Index of item to pre-select.
      * @private
      */
     showCustomizePage_: function(args, index) {
       // Determine whether to bring the OK button field into focus.
       var wasCustomizePageHidden = !this.customizePageVisible_;
       this.customizePageVisible_ = true;
       this.confirmPageVisible_ = false;
 
       $('confirm-sync-preferences').hidden = true;
       $('customize-sync-preferences').hidden = false;
 
       $('sync-custom-passphrase-container').hidden = false;
       $('sync-new-encryption-section-container').hidden = false;
       $('customize-sync-encryption-new').hidden = args.isSupervised;
 
       $('sync-existing-passphrase-container').hidden = true;
 
       $('sync-select-datatypes').selectedIndex = index;
       this.setDataTypeCheckboxesEnabled_(
-          index == DataTypeSelection.CHOOSE_WHAT_TO_SYNC);
+          index == options.DataTypeSelection.CHOOSE_WHAT_TO_SYNC);
 
       // Give the OK button focus only when the dialog wasn't already visible.
       if (wasCustomizePageHidden)
         $('choose-datatypes-ok').focus();
 
       if (args.showPassphrase) {
         this.showPassphraseContainer_(args);
         // Give the passphrase field focus only when the dialog wasn't already
         // visible.
         if (wasCustomizePageHidden)
           $('passphrase').focus();
       } else {
         // We only show the 'Use Default' link if we're not prompting for an
         // existing passphrase.
         $('use-default-link').hidden = false;
         $('use-default-link').disabled = false;
         $('use-default-link').onclick = function() {
           SyncSetupOverlay.showSyncEverythingPage();
           return false;
         };
       }
     },
 
     /**
      * Shows the appropriate sync setup page.
      * @param {string} page A page of the sync setup to show.
-     * @param {object} args Data from the C++ to forward on to the right
+     * @param {Object} args Data from the C++ to forward on to the right
      *     section.
      */
     showSyncSetupPage_: function(page, args) {
       // If the user clicks the OK button, dismiss the dialog immediately, and
       // do not go through the process of hiding elements of the overlay.
       // See crbug.com/308873.
       if (page == 'done') {
         this.closeOverlay_();
         return;
       }
@@ skipping 42 matching lines @@
       var throbbers = this.pageDiv.getElementsByClassName('throbber');
       for (var i = 0; i < throbbers.length; i++)
         throbbers[i].style.visibility = visible ? 'visible' : 'hidden';
     },
 
     /**
      * Reset the state of all descendant elements of a root element to their
      * initial state.
      * The initial state is specified by adding a class to the descendant
      * element in sync_setup_overlay.html.
-     * @param {HTMLElement} pageElementId The root page element id.
+     * @param {string} pageElementId The root page element id.
      * @private
      */
     resetPage_: function(pageElementId) {
       var page = $(pageElementId);
       var forEach = function(arr, fn) {
         var length = arr.length;
         for (var i = 0; i < length; i++) {
           fn(arr[i]);
         }
       };
@@ skipping 89 matching lines @@
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });