Compile chrome://settings, part 2: reduce from 950 to 400 errors

ui/webui/resources/js/cr/ui/bubble_button.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cr.ui', function() {
   /**
    * An image button that brings up an informative bubble when activated by
    * keyboard or mouse.
    * @constructor
    * @extends {HTMLSpanElement}
+   * @implements {EventListener}
    */
   var BubbleButton = cr.ui.define('span');
 
   BubbleButton.prototype = {
     __proto__: HTMLSpanElement.prototype,
 
     /**
      * Decorates the base element to show the proper icon.
      */
     decorate: function() {
@@ skipping 47 matching lines @@
         case 'mousedown':
           if (document.activeElement)
             document.activeElement.blur();
           event.preventDefault();
           return;
       }
       this.toggleBubble_();
       event.preventDefault();
       event.stopPropagation();
     },
+
+    /**
+     * Abstract method: subclasses should overwrite it. There is no way to mark
+     *     method as abstract for Closure Compiler, as of
+     *     https://github.com/google/closure-compiler/issues/104.
+     * @type {!Function|undefined}
+     * @protected
+     */
+    toggleBubble_: undefined

[Dan Beam, 2014/09/06 02:22:39]

nit: ,

[Dan Beam, 2014/09/06 02:22:39]

nit: maybe instead:

  toggleBubble: assertNotReached,

?

[Dan Beam, 2014/09/06 02:22:39]

@protected methods aren't suffixed with _, only @private

[Vitaly Pavlenko, 2014/09/06 22:54:09]

Done.

[Vitaly Pavlenko, 2014/09/06 22:54:09]

Done.

[Vitaly Pavlenko, 2014/09/06 22:54:09]

Done.

   };
 
   // Export.
   return {
     BubbleButton: BubbleButton
   };
 });