Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/resources/options/website_settings.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var Page = cr.ui.pageManager.Page; 6 /** @const */ var Page = cr.ui.pageManager.Page;
7 /** @const */ var PageManager = cr.ui.pageManager.PageManager; 7 /** @const */ var PageManager = cr.ui.pageManager.PageManager;
8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
9 9
10 ///////////////////////////////////////////////////////////////////////////// 10 /////////////////////////////////////////////////////////////////////////////
11 // WebsiteSettingsManager class: 11 // WebsiteSettingsManager class:
12 12
13 /** 13 /**
14 * Encapsulated handling of the website settings page. 14 * Encapsulated handling of the website settings page.
15 * @constructor 15 * @constructor
16 * @extends {cr.ui.pageManager.Page}
16 */ 17 */
17 function WebsiteSettingsManager() { 18 function WebsiteSettingsManager() {
18 Page.call(this, 'websiteSettings', 19 Page.call(this, 'websiteSettings',
19 loadTimeData.getString('websitesOptionsPageTabTitle'), 20 loadTimeData.getString('websitesOptionsPageTabTitle'),
20 'website-settings-page'); 21 'website-settings-page');
21 } 22 }
22 23
23 cr.addSingletonGetter(WebsiteSettingsManager); 24 cr.addSingletonGetter(WebsiteSettingsManager);
24 25
25 WebsiteSettingsManager.prototype = { 26 WebsiteSettingsManager.prototype = {
26 __proto__: Page.prototype, 27 __proto__: Page.prototype,
27 28
28 /** 29 /**
29 * The saved origins list. 30 * The saved origins list.
30 * @type {OriginList} 31 * @type {options.OriginList}
31 * @private 32 * @private
32 */ 33 */
33 originList_: null, 34 originList_: null,
34 35
35 /** @override */ 36 /** @override */
36 initializePage: function() { 37 initializePage: function() {
37 Page.prototype.initializePage.call(this); 38 Page.prototype.initializePage.call(this);
38 39
39 $('website-settings-overlay-confirm').onclick = 40 $('website-settings-overlay-confirm').onclick =
40 PageManager.closeOverlay.bind(PageManager); 41 PageManager.closeOverlay.bind(PageManager);
41 42
42 $('resourceType').onchange = function() { 43 $('resourceType').onchange = function(event) {
43 var target = event.target; 44 var target = event.target;
Dan Beam 2014/09/06 02:22:38 hmmmm, wonder if this worked before...
44 assert(target.tagName == 'SELECT'); 45 assert(target.tagName == 'SELECT');
45 if (target.value == 'storage') 46 if (target.value == 'storage')
46 chrome.send('updateLocalStorage'); 47 chrome.send('updateLocalStorage');
47 else if (target.value == 'battery') 48 else if (target.value == 'battery')
48 chrome.send('updateBatteryUsage'); 49 chrome.send('updateBatteryUsage');
49 else 50 else
50 chrome.send('updateOrigins', [target.value]); 51 chrome.send('updateOrigins', [target.value]);
51 }; 52 };
52 53
53 var searchBox = $('website-settings-search-box'); 54 var searchBox = $('website-settings-search-box');
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 129
129 WebsiteSettingsManager.showEditPage = function(url) { 130 WebsiteSettingsManager.showEditPage = function(url) {
130 WebsiteSettingsEditor.getInstance().populatePage(url); 131 WebsiteSettingsEditor.getInstance().populatePage(url);
131 }; 132 };
132 133
133 // Export 134 // Export
134 return { 135 return {
135 WebsiteSettingsManager: WebsiteSettingsManager 136 WebsiteSettingsManager: WebsiteSettingsManager
136 }; 137 };
137 }); 138 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698