Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/preferences.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   /////////////////////////////////////////////////////////////////////////////
   // Preferences class:
 
   /**
    * Preferences class manages access to Chrome profile preferences.
    * @constructor
+   * @extends {cr.EventTarget}
    */
   function Preferences() {
     // Map of registered preferences.
     this.registeredPreferences_ = {};
   }
 
   cr.addSingletonGetter(Preferences);
 
   /**
    * Sets a Boolean preference and signals its new value.
    * @param {string} name Preference name.
    * @param {boolean} value New preference value.
    * @param {boolean} commit Whether to commit the change to Chrome.
-   * @param {string} metric User metrics identifier.
+   * @param {string=} opt_metric User metrics identifier.
    */
-  Preferences.setBooleanPref = function(name, value, commit, metric) {
+  Preferences.setBooleanPref = function(name, value, commit, opt_metric) {
     if (!commit) {
       Preferences.getInstance().setPrefNoCommit_(name, 'bool', Boolean(value));
       return;
     }
 
     var argumentList = [name, Boolean(value)];
-    if (metric != undefined) argumentList.push(metric);
+    if (opt_metric != undefined) argumentList.push(opt_metric);
     chrome.send('setBooleanPref', argumentList);
   };
 
   /**
    * Sets an integer preference and signals its new value.
    * @param {string} name Preference name.
    * @param {number} value New preference value.
    * @param {boolean} commit Whether to commit the change to Chrome.
    * @param {string} metric User metrics identifier.
    */
@@ skipping 79 matching lines @@
     var argumentList = [name, JSON.stringify(value)];
     if (metric != undefined) argumentList.push(metric);
     chrome.send('setListPref', argumentList);
   };
 
   /**
    * Clears the user setting for a preference and signals its new effective
    * value.
    * @param {string} name Preference name.
    * @param {boolean} commit Whether to commit the change to Chrome.
-   * @param {string} metric User metrics identifier.
+   * @param {string=} opt_metric User metrics identifier.
    */
-  Preferences.clearPref = function(name, commit, metric) {
+  Preferences.clearPref = function(name, commit, opt_metric) {
     if (!commit) {
       Preferences.getInstance().clearPrefNoCommit_(name);
       return;
     }
 
     var argumentList = [name];
-    if (metric != undefined) argumentList.push(metric);
+    if (opt_metric != undefined) argumentList.push(opt_metric);
     chrome.send('clearPref', argumentList);
   };
 
   Preferences.prototype = {
     __proto__: cr.EventTarget.prototype,
 
     /**
      * Adds an event listener to the target.
      * @param {string} type The name of the event.
      * @param {!Function|{handleEvent:Function}} handler The handler for the
@@ skipping 16 matching lines @@
         params2.push(prefName);
       }
       chrome.send('fetchPrefs', params1);
       chrome.send('observePrefs', params2);
     },
 
     /**
      * Helper function for flattening of dictionary passed via fetchPrefs
      * callback.
      * @param {string} prefix Preference name prefix.
-     * @param {object} dict Map with preference values.
+     * @param {Object} dict Map with preference values.
      * @private
      */
     flattenMapAndDispatchEvent_: function(prefix, dict) {
       for (var prefName in dict) {
         var value = dict[prefName];
         if (typeof value == 'object' &&
             !this.registeredPreferences_[prefix + prefName]) {
           this.flattenMapAndDispatchEvent_(prefix + prefName + '.', value);
         } else if (value) {
           var event = new Event(prefix + prefName);
@@ skipping 109 matching lines @@
 
       var event = new Event(name);
       event.value = pref.orig || {};
       event.value.uncommitted = true;
       this.dispatchEvent(event);
     }
   };
 
   /**
    * Callback for fetchPrefs method.
-   * @param {object} dict Map of fetched property values.
+   * @param {Object} dict Map of fetched property values.
    */
   Preferences.prefsFetchedCallback = function(dict) {
     Preferences.getInstance().flattenMapAndDispatchEvent_('', dict);
   };
 
   /**
    * Callback for observePrefs method.
-   * @param {array} notification An array defining changed preference values.
-   * notification[0] contains name of the change preference while its new value
-   * is stored in notification[1].
+   * @param {Array} notification An array defining changed preference values.
+   *     notification[0] contains name of the change preference while its new
+   *     value is stored in notification[1].
    */
   Preferences.prefsChangedCallback = function(notification) {
     var event = new Event(notification[0]);
     event.value = notification[1];
-    prefs = Preferences.getInstance();
+    var prefs = Preferences.getInstance();
     prefs.registeredPreferences_[notification[0]] = {orig: notification[1]};
     if (event.value)
       prefs.dispatchEvent(event);
   };
 
   // Export
   return {
     Preferences: Preferences
   };
 
 });