Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManageProfileOverlay class
    * Encapsulated handling of the 'Manage profile...' overlay page.
    * @constructor
-   * @class
+   * @extends {cr.ui.pageManager.Page}
    */
   function ManageProfileOverlay() {
     Page.call(this, 'manageProfile',
               loadTimeData.getString('manageProfileTabTitle'),
               'manage-profile-overlay');
   };
 
   cr.addSingletonGetter(ManageProfileOverlay);
 
   ManageProfileOverlay.prototype = {
@@ skipping 355 matching lines @@
           // Check if another supervised user also exists with that name.
           var nameIsUnique = true;
           var j;
           for (j = i + 1; j < supervisedUsers.length; ++j) {
             if (supervisedUsers[j].name == newName) {
               nameIsUnique = false;
               break;
             }
           }
           var self = this;
-          function getImportHandler(supervisedUser, nameIsUnique) {
+          var getImportHandler = function(supervisedUser, nameIsUnique) {
             return function() {
               if (supervisedUser.needAvatar || !nameIsUnique) {
                 PageManager.showPageByName('supervisedUserImport');
               } else {
                 self.hideErrorBubble_('create');
                 CreateProfileOverlay.updateCreateInProgress(true);
                 chrome.send('createProfile',
                     [supervisedUser.name, supervisedUser.iconURL, false, true,
                          supervisedUser.id]);
               }
             }
           };

[Dan Beam, 2014/09/06 02:22:36]

it'd probably be better just to remove the ; at the end

[Vitaly Pavlenko, 2014/09/06 22:54:08]

##
/usr/local/google/home/vitalyp/src/chrome/browser/resources/options/manage_profile_overlay.js:390:
ERROR - functions can only be declared at top level or immediately within
another function in ES5 strict mode
##           function getImportHandler(supervisedUser, nameIsUnique) {
##           ^
## 

[Dan Beam, 2014/09/09 02:59:09]

probably still better to put at the top of the function instead

[Vitaly Pavlenko, 2014/09/09 17:54:51]

Not sure, if I'm doing it right. Please, have a look.

           $('supervised-user-import-existing').onclick =
               getImportHandler(supervisedUsers[i], nameIsUnique);
           $('create-profile-ok').disabled = true;
           return;
         }
       }
     },
 
     /**
      * Called in case the request for the list of supervised users fails because
@@ skipping 450 matching lines @@
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });