Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/font_settings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
@@ skipping 137 matching lines @@
       Preferences.setIntegerPref(
         'webkit.webprefs.minimum_logical_font_size', size, true);
       return false;
     },
 
     /**
      * Sets the text, font size and font family of the sample text.
      * @param {Element} el The div containing the sample text.
      * @param {number} size The font size of the sample text.
      * @param {string} font The font family of the sample text.
-     * @param {bool} showSize True if the font size should appear in the sample.
+     * @param {boolean} showSize True if the font size should appear in the
+     *     sample.
      * @private
      */
     setUpFontSample_: function(el, size, font, showSize) {
       var prefix = showSize ? (size + ': ') : '';
       el.textContent = prefix +
           loadTimeData.getString('fontSettingsLoremIpsum');
       el.style.fontSize = size + 'px';
       if (font)
         el.style.fontFamily = font;
     },
 
     /**
      * Populates a select list and selects the specified item.
      * @param {Element} element The select element to populate.
      * @param {Array} items The array of items from which to populate.
      * @param {string} selectedValue The selected item.
      * @private
      */
     populateSelect_: function(element, items, selectedValue) {
       // Remove any existing content.
       element.textContent = '';
 
       // Insert new child nodes into select element.
-      var value, text, selected, option;
+      var value, text, dir, selected, option;
       for (var i = 0; i < items.length; i++) {
         value = items[i][0];

[Dan Beam, 2014/09/06 02:22:36]

nit: I'd say just put var instead here, i.e.

  var value = items[i][0];

it's not really making a block-level variable, but it is the first rule in the
style guide:
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#var

[Vitaly Pavlenko, 2014/09/06 22:54:08]

Done.

         text = items[i][1];
         dir = items[i][2];
         if (text) {
           selected = value == selectedValue;
           var option = new Option(text, value, false, selected);
           option.dir = dir;
           element.appendChild(option);
         } else {
           element.appendChild(document.createElement('hr'));
         }
@@ skipping 54 matching lines @@
     $('advanced-font-settings-install').hidden = available;
     $('advanced-font-settings-options').hidden = !available;
   };
 
   // Export
   return {
     FontSettings: FontSettings
   };
 });