Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/cookies_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
@@ skipping 39 matching lines @@
    * when the page is zoomed. See the similar calculation in @{code cr.ui.List}.
    * This version also accounts for the animation done in this file.
    * @param {Element} item The item to get the height of.
    * @return {number} The height of the item, calculated with zooming in mind.
    */
   function getItemHeight(item) {
     var height = item.style.height;
     // Use the fixed animation target height if set, in case the element is
     // currently being animated and we'd get an intermediate height below.
     if (height && height.substr(-2) == 'px')
-      return parseInt(height.substr(0, height.length - 2));
+      return parseInt(height.substr(0, height.length - 2), 10);
     return item.getBoundingClientRect().height;
   }
 
   /**
    * Create tree nodes for the objects in the data array, and insert them all
    * into the given list using its @{code splice} method at the given index.
    * @param {Array.<Object>} data The data objects for the nodes to add.
    * @param {number} start The index at which to start inserting the nodes.
    * @return {Array.<CookieTreeNode>} An array of CookieTreeNodes added.
    */
   function spliceTreeNodes(data, start, list) {
     var nodes = data.map(function(x) { return new CookieTreeNode(x); });
     // Insert [start, 0] at the beginning of the array of nodes, making it
     // into the arguments we want to pass to @{code list.splice} below.
     nodes.splice(0, 0, start, 0);
     list.splice.apply(list, nodes);
     // Remove the [start, 0] prefix and return the array of nodes.
     nodes.splice(0, 2);
     return nodes;
   }
 
   /**
    * Adds information about an app that protects this data item to the
-   * @{code element}.
+   * |element|.
    * @param {Element} element The DOM element the information should be
          appended to.
    * @param {{id: string, name: string}} appInfo Information about an app.
    */
   function addAppInfo(element, appInfo) {
     var img = element.ownerDocument.createElement('img');
     img.src = 'chrome://extension-icon/' + appInfo.id + '/16/1';
     element.title = loadTimeData.getString('label_protected_by_apps') +
                     ' ' + appInfo.name;
     img.className = 'protecting-app';
     element.appendChild(img);
   }
 
   var parentLookup = {};
   var lookupRequests = {};
 
   /**
    * Creates a new list item for sites data. Note that these are created and
    * destroyed lazily as they scroll into and out of view, so they must be
    * stateless. We cache the expanded item in @{code CookiesList} though, so it
    * can keep state. (Mostly just which item is selected.)
    * @param {Object} origin Data used to create a cookie list item.
-   * @param {CookiesList} list The list that will contain this item.
+   * @param {options.CookiesList} list The list that will contain this item.
    * @constructor
-   * @extends {DeletableItem}
+   * @extends {options.DeletableItem}
    */
   function CookieListItem(origin, list) {
     var listItem = new DeletableItem(null);
     listItem.__proto__ = CookieListItem.prototype;
 
     listItem.origin = origin;
     listItem.list = list;
     listItem.decorate();
 
     // This hooks up updateOrigin() to the list item, makes the top-level
@@ skipping 102 matching lines @@
       if (!this.classList.contains('measure-items'))
         this.disableAnimation_();
       this.itemsChild.style.height = '';
       // This will force relayout in order to calculate the new heights.
       var itemsHeight = getItemHeight(this.itemsChild);
       var fixedHeight = getItemHeight(this) + itemsHeight - this.itemsHeight_;
       this.itemsChild.style.height = this.itemsHeight_ + 'px';
       // Force relayout before enabling animation, so that if we have
       // changed things since the last layout, they will not be animated
       // during subsequent layouts.
+      /** @suppress {suspiciousCode} */
       this.itemsChild.offsetHeight;
       this.classList.remove('measure-items');
       this.itemsChild.style.height = itemsHeight + 'px';
       this.style.height = fixedHeight + 'px';
     },
 
     /**
      * Updates the origin summary to reflect changes in its items.
      * Both CookieListItem and CookieTreeNode implement this API.
      * This implementation scans the descendants to update the text.
@@ skipping 92 matching lines @@
     /**
      * Get the currently selected cookie node ("cookie bubble") index.
      * @type {number}
      */
     get selectedIndex() {
       return this.selectedIndex_;
     },
 
     /**
      * Set the currently selected cookie node ("cookie bubble") index to
-     * @{code itemIndex}, unselecting any previously selected node first.
+     * |itemIndex|, unselecting any previously selected node first.
      * @param {number} itemIndex The index to set as the selected index.
      */
     set selectedIndex(itemIndex) {
       // Get the list index up front before we change anything.
       var index = this.list.getIndexOfListItem(this);
       // Unselect any previously selected item.
       if (this.selectedIndex_ >= 0) {
         var item = this.itemList_[this.selectedIndex_];
         if (item && item.div)
           item.div.removeAttribute('selected');
@@ skipping 315 matching lines @@
       if (parent && parent instanceof CookieTreeNode)
         return parent.pathId + ',' + this.data.id;
       return this.data.id;
     },
   };
 
   /**
    * Creates a new cookies list.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
-   * @extends {DeletableItemList}
+   * @extends {options.DeletableItemList}
    */
   var CookiesList = cr.ui.define('list');
 
   CookiesList.prototype = {
     __proto__: DeletableItemList.prototype,
 
     /** @override */
     decorate: function() {
       DeletableItemList.prototype.decorate.call(this);
       this.classList.add('cookie-list');
@@ skipping 227 matching lines @@
       parent.clear();
       this.addByParent_(parent, 0, children);
       parent.endBatchUpdates();
     },
   };
 
   return {
     CookiesList: CookiesList
   };
 });