Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/content_settings_exceptions_area.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.contentSettings', function() {
   /** @const */ var ControlledSettingIndicator =
                     options.ControlledSettingIndicator;
   /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
   /** @const */ var InlineEditableItem = options.InlineEditableItem;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
@@ skipping 160 matching lines @@
               this.dataItem.source : null;
 
       if (controlledBy) {
         this.setAttribute('controlled-by', controlledBy);
         this.deletable = false;
         this.editable = false;
       }
 
       if (controlledBy == 'policy' || controlledBy == 'extension') {
         this.querySelector('.row-delete-button').hidden = true;
-        var indicator = ControlledSettingIndicator();
+        var indicator = new ControlledSettingIndicator();
         indicator.setAttribute('content-exception', this.contentType);
         // Create a synthetic pref change event decorated as
         // CoreOptionsHandler::CreateValueForPref() does.
         var event = new Event(this.contentType);
         event.value = { controlledBy: controlledBy };
         indicator.handlePrefChange(event);
         this.appendChild(indicator);
       }
 
       // If the exception comes from a hosted app, display the name and the
@@ skipping 28 matching lines @@
     },
 
     /**
      * The pattern (e.g., a URL) for the exception.
      *
      * @type {string}
      */
     get pattern() {
       if (!this.isEmbeddingRule()) {
         return this.dataItem.origin;
       } else {

[Dan Beam, 2014/09/06 02:22:36]

nit:

  if (!this.isEmbeddingRule())
    return this.dataItem.origin;

  return loadTimeData.getStringF('embeddedOnHost',
                                 this.dataItem.embeddingOrigin);

[Vitaly Pavlenko, 2014/09/06 22:54:08]

Done.

         return loadTimeData.getStringF('embeddedOnHost',
                                        this.dataItem.embeddingOrigin);
       }
-
-      return this.dataItem.displayPattern;
     },
     set pattern(pattern) {
       if (!this.editable)
         console.error('Tried to change uneditable pattern');
 
       this.dataItem.displayPattern = pattern;
     },
 
     /**
      * The setting (allow/block) for the exception.
@@ skipping 147 matching lines @@
   /**
    * Creates a new list item for the Add New Item row, which doesn't represent
    * an actual entry in the exceptions list but allows the user to add new
    * exceptions.
    *
    * @param {string} contentType The type of the list.
    * @param {string} mode The browser mode, 'otr' or 'normal'.
    * @param {boolean} enableAskOption Whether to show an 'ask every time' option
    *     in the select.
    * @constructor
-   * @extends {cr.ui.ExceptionsListItem}
+   * @extends {options.contentSettings.ExceptionsListItem}
    */
   function ExceptionsAddRowListItem(contentType, mode, enableAskOption) {
     var el = cr.doc.createElement('div');
     el.mode = mode;
     el.contentType = contentType;
     el.enableAskOption = enableAskOption;
     el.dataItem = [];
     el.__proto__ = ExceptionsAddRowListItem.prototype;
     el.decorate();
 
@@ skipping 112 matching lines @@
       var args = [0, deleteCount];
       args.push.apply(args, entries);
       this.dataModel.splice.apply(this.dataModel, args);
     },
 
     /**
      * The browser has finished checking a pattern for validity. Update the list
      * item to reflect this.
      *
      * @param {string} pattern The pattern.
-     * @param {bool} valid Whether said pattern is valid in the context of a
+     * @param {boolean} valid Whether said pattern is valid in the context of a
      *     content exception setting.
      */
     patternValidityCheckComplete: function(pattern, valid) {
       var listItems = this.items;
       for (var i = 0; i < listItems.length; i++) {
         var listItem = listItems[i];
         // Don't do anything for messages for the item if it is not the intended
         // recipient, or if the response is stale (i.e. the input value has
         // changed since we sent the request to analyze it).
         if (pattern == listItem.input.value)
@@ skipping 42 matching lines @@
     },
   };
 
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
   /**
    * Encapsulated handling of content settings list subpage.
    *
    * @constructor
+   * @extends {cr.ui.pageManager.Page}
    */
   function ContentSettingsExceptionsArea() {
     Page.call(this, 'contentExceptions',
               loadTimeData.getString('contentSettingsPageTabTitle'),
               'content-settings-exceptions-area');
   }
 
   cr.addSingletonGetter(ContentSettingsExceptionsArea);
 
   ContentSettingsExceptionsArea.prototype = {
@@ skipping 76 matching lines @@
     }
   };
 
   return {
     ExceptionsListItem: ExceptionsListItem,
     ExceptionsAddRowListItem: ExceptionsAddRowListItem,
     ExceptionsList: ExceptionsList,
     ContentSettingsExceptionsArea: ContentSettingsExceptionsArea,
   };
 });