Compile chrome://settings, part 2: reduce from 950 to 400 errors

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
@@ skipping 738 matching lines @@
       section.hidden = false;
       section.style.height = (showing ? 0 : container.offsetHeight) + 'px';
       section.classList.add('sliding');
 
       if (this.sectionHeightChangeTimeout_ !== null)
         clearTimeout(this.sectionHeightChangeTimeout_);
 
       this.sectionHeightChangeTimeout_ = setTimeout(function() {
         section.style.height = (showing ? container.offsetHeight : 0) + 'px';
         this.sectionHeightChangeTimeout_ = null;
-      });
+      }, 0);
     },
 
     /**
      * Shows the given section.
      * @param {HTMLElement} section The section to be shown.
      * @param {HTMLElement} container The container for the section. Must be
      *     inside of |section|.
      * @param {boolean} animate Indicate if the expansion should be animated.
      * @private
      */
@@ skipping 375 matching lines @@
      * doesn't start with 'http://' it is returned unchanged.
      * @param {string} url The url to be processed
      * @return {string} The url with the 'http://' removed.
      */
     stripHttp_: function(url) {
       return url.replace(/^http:\/\//, '');
     },
 
    /**
     * Shows the autoLaunch preference and initializes its checkbox value.
-    * @param {bool} enabled Whether autolaunch is enabled or or not.
+    * @param {boolean} enabled Whether autolaunch is enabled or or not.
     * @private
     */
     updateAutoLaunchState_: function(enabled) {
       $('auto-launch-option').hidden = false;
       $('auto-launch').checked = enabled;
     },
 
     /**
      * Called when the value of the download.default_directory preference
      * changes.
@@ skipping 362 matching lines @@
     setMetricsReportingSettingVisibility_: function(visible) {
       if (visible)
         $('metricsReportingSetting').style.display = 'block';
       else
         $('metricsReportingSetting').style.display = 'none';
     },
 
     /**
      * Set network prediction checkbox value.
      *
-     * @param {Object} pref Information about network prediction options.
-     * @param {number} pref.value The value of network prediction options.
-     * @param {boolean} pref.disabled If the pref is not user modifiable.
+     * @param {{value: number, disabled: boolean}} pref Information about
+     *     network prediction options. |pref.value| is the value of network
+     *     prediction options. |pref.disabled| shows if the pref is not user
+     *     modifiable.
      * @private
      */
     setNetworkPredictionValue_: function(pref) {
       var checkbox = $('networkPredictionOptions');
       checkbox.disabled = pref.disabled;
       if (pref.value == NetworkPredictionOptions.UNSET) {
         checkbox.checked = (NetworkPredictionOptions.DEFAULT !=
             NetworkPredictionOptions.NEVER);
       } else {
         checkbox.checked = (pref.value != NetworkPredictionOptions.NEVER);
       }
     },
 
     /**
      * Set the font size selected item. This item actually reflects two
      * preferences: the default font size and the default fixed font size.
      *
-     * @param {Object} pref Information about the font size preferences.
-     * @param {number} pref.value The value of the default font size pref.
-     * @param {boolean} pref.disabled True if either pref not user modifiable.
-     * @param {string} pref.controlledBy The source of the pref value(s) if
-     *     either pref is currently not controlled by the user.
+     * @param {{value: number, disabled: boolean, controlledBy: string}} pref

[Dan Beam, 2014/09/06 02:22:36]

might be worth a typedef between here and L1538

[Vitaly Pavlenko, 2014/09/06 22:54:07]

I don't think so. These are formed and called by two different places in
.cc-source:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

+     *     Information about the font size preferences. |pref.value| is the
+     *     value of the default font size pref. |pref.disabled| is true if
+     *     either pref not user modifiable. |pref.controlledBy| is the source of
+     *     the pref value(s) if either pref is currently not controlled by the
+     *     user.
      * @private
      */
     setFontSize_: function(pref) {
       var selectCtl = $('defaultFontSize');
       selectCtl.disabled = pref.disabled;
       // Create a synthetic pref change event decorated as
       // CoreOptionsHandler::CreateValueForPref() does.
       var event = new Event('synthetic-font-size');
       event.value = {
         value: pref.value,
@@ skipping 406 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });