Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 543403004: App list PaginationModel: Use FAST_OUT_SLOW_IN for page tweening. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mclement
Base URL:
https://chromium.googlesource.com/chromium/src.git@app-list-transition-ease
Project:
chromium
Visibility:
Public.

Description

App list PaginationModel: Use FAST_OUT_SLOW_IN for page tweening. This is a very minor change to the motion of pages (fast start and slow end), but brings the launcher in line with the material design spec. BUG=406222 Committed: https://crrev.com/47fd5efc2beccec3a4eff5ea8953df08d7012d3b Cr-Commit-Position: refs/heads/master@{#294341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/app_list/pagination_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Matt Giuca
Note: Discussed with mclement about which curve to use. I think FAST_OUT_SLOW_IN is misnamed because ...
6 years, 3 months ago (2014-09-11 01:36:41 UTC) #2
Matt Giuca
See email from Manuel: the name makes sense if you think of "out" as "starting ...
6 years, 3 months ago (2014-09-11 03:54:19 UTC) #3
calamity
lgtm
6 years, 3 months ago (2014-09-11 05:16:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543403004/1
6 years, 3 months ago (2014-09-11 05:17:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10d0276a914e44d30372679e3076b407d052baec
6 years, 3 months ago (2014-09-11 06:29:50 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 06:35:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47fd5efc2beccec3a4eff5ea8953df08d7012d3b
Cr-Commit-Position: refs/heads/master@{#294341}

Powered by Google App Engine
This is Rietveld 408576698